Improve conversion / change internal parameter logic

This merge requests changes how the parameter conversion works for CBCs and GWs in general.

It's required a small change to the user interface, namely the removal of the hideous non_standard_sampling_parameter_keys kwarg. I've updated the example to use the new syntax.

I think this is worth the change in syntax as it's now much slicker.

added 1 commit

• 6e34491f - flake8 fixes

Compare with previous version

added 1 commit

• d89108b5 - attempt to fix python 2 list copy

Compare with previous version

approved this merge request

I really like this.

There is still a reference to non_standard_sampling_parameters in gw.likelihood that you should remove, though. Also there is a reference to it in PriorSet.fill_prior and in some of the prior tests.

marked as a Work In Progress

changed the description

added 6 commits

• af03c145 - pretty radically change the way parameters are passed around in waveform generator. Whoops
• 56c09a9f - fix initial assignment issues
• 98d53d94 - fix waveform generator tests
• b55d598c - make likelihood tests run with changes
• 36bff06c - remove broken test
• 6a36ad63 - make change sampled parameters a little more pathological

Compare with previous version

added 2 commits

• 44ada1c5 - update example syntax
• dda0369d - remove old stuff

Compare with previous version

added 1 commit

• 4cba0ca9 - make parameters kwargs optional

Compare with previous version

The scope of this branch has increased pretty drastically. In order to make the conversions work in this more streamlined way required some pretty big changes to the way parameters are passed around inside the WaveformGenerator.

The main changes are:

• wfg.frequency_domain_strain now takes parameters as an argument, it's still possible to call it the old way, but the behaviour may have slightly changed.
• wfg.parameters is no longer the same as likelihood.parameters for the GravitationalWaveTransient. The wfg.parameters are recreated at every iteration from the provided dictionary.
• It can now handle essentially arbitrary input parameters as long as the provided conversion function know how to deal with it.

I hope these changes make the way that parameters are moved around more transparent.

unmarked as a Work In Progress

changed title from Improve conversion to Improve conversion / change internal parameter logic

added 10 commits

• 4cba0ca9...205dadd4 - 9 commits from branch master
• bb1bbdcb - Merge branch 'master' into 'improve_conversion'

Compare with previous version

added 2 commits

• d373638c - typo fix wrapper
• 739385ce - fix repr tests

Compare with previous version

added 1 commit

• a2d0cb8d - remove deprecated test

Compare with previous version

added 1 commit

• 77202e84 - remove obsolete test

Compare with previous version

resolved all discussions

resolved all discussions

added 4 commits

• 77202e84...b0382bfd - 2 commits from branch master
• 8bba093c - Merge branch 'master' into improve_conversion
• bfa83337 - make copying explicit in parameters setter

Compare with previous version

approved this merge request

approved this merge request

merged

mentioned in commit f72981b8

mentioned in issue #195 (closed)