Resolve "Replace inspect.getargspec references"

Closes #208 (closed)

added 3 commits

• 18d0390f - Replaced parameter introspection logic with call to core.utils.infer_parameters_from_function
• 8140dd52 - Removed inspect.getargspec with inspect.signature
• 0ef5bdbc - Replaced parameter introspection logic with call to core.utils.infer_parameters_from_function

Compare with previous version

added 2 commits

• cc1822d6 - Replaced usage of inspect.getargspec with inspect.signature
• e2bad194 - Added tests for inferring parameters from a function

Compare with previous version

added 3 commits

• e8f5a36d - Replaced inspect.getargspec with call to core.utils.infer_args_from_method
• 71d25977 - Added infer_args_from_method and made all the tests work
• 4fa4ae14 - Added some tests and added decorator that stops it from executing in python2

Compare with previous version

added 3 commits

• fe95e57b - Reverted a bit back
• 2f9e60d0 - Removed utils_test.py from gitlab CI
• aa063ba7 - PEP8 stuff

Compare with previous version

added 2 commits

• fa2b36e7 - Added utils_test back to Python2 CI
• 630a0180 - Replaced inspect.signature -> inspect.getfullargspec

Compare with previous version

added 1 commit

• fb4e7cd0 - Refactored a bit

Compare with previous version

added 1 commit

• e390d34f - Now uses the utils.core.infer_args_from_method function

Compare with previous version

added 1 commit

• fa48b2ee - PEP8 and removed tests from Python2 pipeline that don't work in python 2

Compare with previous version

added 1 commit

• 2f1845ed - Now tries both Python2 and Python3 inspect modules

Compare with previous version

added 1 commit

• 80a8828e - Fixed a bug

Compare with previous version

unmarked as a Work In Progress

It looks like you've added a test script and then removed it from the CI. Do you intend to make it run before merging?

EDIT: I see you just removed it from python 2. Can you explain the added functionality in python 3 that justifies this?

resolved all discussions

added 1 commit

• 24996a86 - Refactored code for inspection utils functions into protected function

Compare with previous version

@colm.talbot The reason for excluding this is because I am testing that we correctly functions that implement type hinting, e.g.

def foo(a: int, b: float):
   print('bar')

Type hinting simply does not exist in python 2 and the tests break. There is no good way I have found to work around this without excluding at least the entire test class.

I can see if there is a better solution for this.

It might not be the neatest solution, but can you define the functions inside the test methods? E.g.,

class TestInferParameters(unittest.TestCase):
    
    def setUp(self):
        pass

    def tearDown(self):
        pass

    @pytest.mark.skipif(sys.version_info < (3, 0), reason="requires Python3")
    def test_type_hinting(self):
        def source1(freqs, a, b: int):
            return None
        expected = ['a', 'b']
        actual = utils.infer_parameters_from_function(source1)
        self.assertListEqual(expected, actual)

I can try that and I tried something similar before. I think it may still go wrong because the Python 2 interpreter may not be able to deal with the colon after b.