ROQ implementation into bilby

added 5 commits

• 6c5300c9 - mild refactoring
• 74624f20 - do parameter conversions for ROQ
• 50aef0b5 - slight refactor
• f775452a - refactor ROQ likelihood
• 1838dec7 - update ROQ example

Compare with previous version

unmarked as a Work In Progress

added 3 commits

• d2fae6f6 - remove unwanted print statement
• c5c2b9e5 - make log likelihood real...
• ead88375 - fix phase parameters

Compare with previous version

added 1 commit

• c77e7301 - Adapted test likelihood values to match new expected return values after we…

Compare with previous version

added 1 commit

• 861e9dbc - time-dependent weight implemented

Compare with previous version

added 43 commits

• 861e9dbc...d5c0628b - 31 commits from branch master
• a77e38a2 - Merge branch 'master' into implementing_ROQ
• 7bd1e010 - refactoring
• f7d66d6e - refactoring
• adc90358 - add documentation
• 94079582 - refactoring
• 9fec0ba7 - touch up roq example
• eab5ba5e - add catch for m2>m1
• 8456dd45 - add catch for None waveform
• 5f5055ba - update syntax
• acdb9f96 - catch time prior bounds properly
• e2e89459 - add roq tests
• a692fe75 - remove deprecated StopIteration

Compare with previous version

added 1 commit

• d881751f - remove unused import

Compare with previous version

Add a basis to the test containers so the tests will run, this will require a slight rewrite of the tests. @gregory.ashton

Can someone add some detailed instructions on how to "add a basis". Ideally, add this to the documentation itself (perhaps even a page on the ROQ likelihood subtleties?), but at absolute minimum add something here on what exactly I should add to where. Cheers.

added 48 commits

• d881751f...1d0a4ed3 - 46 commits from branch master
• f40f3122 - Merge branch 'master' into implementing_ROQ
• 4e277271 - update roq path

Compare with previous version

added 1 commit

• 2a27caa6 - flake fix

Compare with previous version

I added the appropriate data to the test images. The example shows how to interact with the basis files.

added 1 commit

• fd2a3a81 - update roq example, changelog

Compare with previous version

added 5 commits

• fd2a3a81...784d0600 - 4 commits from branch master
• 7bacb35f - Merge branch 'master' into implementing_ROQ

Compare with previous version

I resolved a merge conflict

What was the conflict? The tests are now failing.

I keep getting emails about merge conflicts with this - can I do something on my end to fix?

added 102 commits

• 7bacb35f...1f724ae8 - 100 commits from branch master
• 511cabb5 - Merge branch 'master' into implementing_ROQ
• 21d680ac - readd lalsimulation

Compare with previous version

added 1 commit

• 33c51f5f - update ROQ likelihood prior->priors

Compare with previous version

added 1 commit

• 8f24ba62 - flake fix

Compare with previous version

This is ready to go if people want to take another look over. @gregory.ashton @moritz.huebner

approved this merge request

approved this merge request

added 9 commits

• 8f24ba62...8679c5c4 - 8 commits from branch master
• a3750bab - Merge branch 'master' into 'implementing_ROQ'

Compare with previous version

@colm.talbot @gregory.ashton I fixed the tests, it should be working now

added 1 commit

• 5f90a148 - Adapted expected log likelihood values given the changed frequency mask

Compare with previous version

approved this merge request

changed milestone to %0.3.5

I've targeted this for 0.3.5 since there isn't an urgent need (in the next week or two at least). But, I'm working on improving the test suite and I'd prefer to merge this into that, rather than the other way around.

assigned to @gregory.ashton

added 87 commits

• 5f90a148...90413d4e - 86 commits from branch master
• 106350b6 - Merge branch 'master' into implementing_ROQ

Compare with previous version

Okay, this is just waiting for the https://git.ligo.org/lscsoft/ROQ_data to be made public, then I'll add the data to the autobuilt docker images, then this will pass the test, then it will get merged :D

added 1 commit

• a6e197f5 - Update path to the roq_data for the tests

Compare with previous version

added 1 commit

• 43402264 - Update the documentation and example for the ROQ likelihood

Compare with previous version

approved this merge request

approved this merge request

merged

mentioned in commit 930280f6

mentioned in issue #155 (closed)