Skip to content
Snippets Groups Projects

Fix problem with Prior prob and ln_prob if passing multiple samples

Merged Fix problem with Prior prob and ln_prob if passing multiple samples
matthew-pitkin/bilby:fix_prior into master
All threads resolved!
Merged Matthew David Pitkin requested to merge matthew-pitkin/bilby:fix_prior into master
All threads resolved!

The changes in !400 (merged) (in c7b36e76) broke the Grid likelihood as the prob and ln_prob prior methods would not work if multiple samples are passed to them. This MR fixes the problem.

cc @colm.talbot

Edited by Matthew David Pitkin

Merge request reports

Pipeline #54803 passed

Stage: test

Pipeline passed for 50531587 on matthew-pitkin:fix_prior

Approved by
Moritz Huebner Colm Talbot Gregory Ashton

Merged by Moritz HuebnerMoritz Huebner 5 years ago (Mar 28, 2019 1:47am UTC)

Merge details

  • Changes merged into master with 99425cde (commits were squashed).
  • Deleted the source branch.

Pipeline #55114 passed with warnings

Stage: test
Stage: deploy

Pipeline passed with warnings for 99425cde on master

Test coverage 72.00% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot
    Colm Talbot @colm.talbot ·
    Maintainer

    That is a quick catch of a new bug!

  • Matthew David Pitkin resolved all discussions

    resolved all discussions

  • Matthew David Pitkin added 1 commit

    added 1 commit

    Compare with previous version

  • Matthew David Pitkin
    Matthew David Pitkin @matthew-pitkin ·
    Author Developer

    Yep, I just happened to be doing some grid comparisons to sampled posteriors this morning and I hit the problem.

  • Matthew David Pitkin resolved all discussions

    resolved all discussions

  • Colm Talbot approved this merge request

    approved this merge request

  • Gregory Ashton approved this merge request

    approved this merge request

  • Moritz Huebner approved this merge request

    approved this merge request

  • Moritz Huebner merged

    merged

  • Moritz Huebner mentioned in commit 99425cde

    mentioned in commit 99425cde

  • Gregory Ashton changed milestone to %0.4.4

    changed milestone to %0.4.4

    • Please register or sign in to reply