Resolve "Add checking to the ROQ usage"
Closes #320 (closed)
- Adds testing which will cover the standard use cases (i.e. component mass sampling and chirp mass / mass ratio)
- No spins checking
- Adds methods to simplify calculating the minimum and maximums to the prior
- Adds testing and allows ROQ tests to be run locally or on CIT (using some predefined guesses as to where to find the bases)
Merge request reports
Activity
changed milestone to %1.0.0
removed Bug label
@colm.talbot requests
-
Add an
ignore_roq_checkkwarg
Edited by Gregory Ashton-
Add an
-
- Add testing
Edited by Gregory Ashton changed milestone to %0.5.4
added 1 commit
- d27b7b1e - Add kwarg to allow by passing of the check, docs, and fix tests
changed milestone to %0.5.5
-
Delaying until @colm.talbot has double checked if this is compatible with rescaled ROQs
added 71 commits
-
7580b452...b7d10dbc - 70 commits from branch
master - b993740e - Merge branch 'master' into 320-add-checking-to-the-roq-usage
-
7580b452...b7d10dbc - 70 commits from branch
changed milestone to %1.0.0
-
The current implementation of this doesn't work with rescaling. In particular, the rescaled frequency minimum will cause this code to bug out.
It isn't clear to me what the best solution is, it feels like the rescaling should really be done in the likelihood itself so that the check can be handled consistently, but that goes beyond the scope of this MR. Therefore, I'm currently going to put this back to WIP while we deal with other more pressing issues.
added 123 commits
-
b993740e...a9bf5dc4 - 121 commits from branch
master - 9a6199f5 - Merge branch 'master' into 320-add-checking-to-the-roq-usage
- feb1548c - Merge branch '320-add-checking-to-the-roq-usage' of git.ligo.org:Monash/tupak...
-
b993740e...a9bf5dc4 - 121 commits from branch
changed milestone to %0.6.0
Resolved by Colm TalbotWould you mind adding a test that creates a likelihood with a scale factor of 1 / 2? Just a test that it doesn't throw an error if the chirp mass range is
26-90rather than13-45.- Last reply by Colm Talbot
mentioned in commit 8e54566f