Skip to content
Snippets Groups Projects

Resolve issues identified in !408

Merged Resolve issues identified in !408
update-constants-and-gmst-conversion into master
All threads resolved!
Merged Gregory Ashton requested to merge update-constants-and-gmst-conversion into master
All threads resolved!
  1. Make the constants consistent with those used in lal
  2. Deprecate the gps_time_to_gmst function
  3. Use the lal.GreenwichMeanSiderealTime(time) method directly

Merge request reports

Pipeline #79352 passed

Stage: test

Pipeline passed for 3c00b32a on update-constants-and-gmst-conversion

Test coverage 70.00% (0.00%) from 1 job
Approval is optional

Merged by Gregory AshtonGregory Ashton 5 years ago (Sep 17, 2019 12:16am UTC)

Pipeline #80078 passed with warnings

Stage: test
Stage: deploy

Pipeline passed with warnings for ea619d83 on master

Test coverage 70.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gregory Ashton added 1 deleted label

    added 1 deleted label

  • Colm Talbot approved this merge request

    approved this merge request

  • Moritz Huebner resolved all threads

    resolved all threads

  • Moritz Huebner approved this merge request

    approved this merge request

  • Gregory Ashton merged

    merged

  • Gregory Ashton mentioned in commit ea619d83

    mentioned in commit ea619d83

  • Gregory Ashton mentioned in merge request !605 (merged)

    mentioned in merge request !605 (merged)

    • Please register or sign in to reply