Skip to content
Snippets Groups Projects

Reorder prior reading

Merged Colm Talbot requested to merge reorder-prior-reading into master

This MR reorders the set of things attempted when trying to parse the prior argument strings. The previous method was causing issues, e.g., the one identified in !617 (merged).

I hope the new order makes a bit more logical sense than the old way. A more descriptive error message is raised and I added a docstring so that future developers will hopefully follow better what is going on.

This will strip the r'' from any parameters that are passed as raw strings, e.g., r'foo' will just render as foo.

@sylvia.biscoveanu can you test this on the prior you had issues with.

Merge request reports

Pipeline #83039 passed

Pipeline passed for 5a9dcc08 on reorder-prior-reading

Test coverage 70.00% (0.00%) from 1 job
Approval is optional

Merged by Gregory AshtonGregory Ashton 5 years ago (Oct 15, 2019 11:23pm UTC)

Merge details

  • Changes merged into master with 3e706657 (commits were squashed).
  • Deleted the source branch.

Pipeline #84030 passed with warnings

Pipeline passed with warnings for 3e706657 on master

Test coverage 70.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading