Skip to content
Snippets Groups Projects

WIP: Prior clean up

Closed Moritz Huebner requested to merge prior_clean_up into master
All threads resolved!

Requires !688 (merged)

Some code improvements for the prior package:

  • Cleaned up a bunch of warnings
  • removed if/else-clauses for prob/rescale/ln_prob/cdf methods that distinguish between float and array input. It now always uses the array logic and then checks the type to return a float if it is a float input
  • Introduced @valid_rescale_check and @consistent_type_use decorators to reduce redundant code throughout the package
  • Restructured the prior tests into its own package
  • Assured that prior saving/loading is still working the same way.
  • Got rid off the check_range_nonzero argument in favour of dynamic testing with properties
Edited by Moritz Huebner

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot
  • Moritz Huebner resolved all threads

    resolved all threads

  • Moritz Huebner added 9 commits

    added 9 commits

    • dbbcddd4 - Removed Python 2 specific handling in repr test
    • 4d05cdbd - Fixed a typo introduced when manually merging
    • 03a6c405 - changed no_rescale_check -> rescale_check
    • b52b861d - Simplified some expressions
    • 2eb8eb91 - Made IS_FIXED a public class attribute
    • 28288be5 - Added new prior feature information
    • d1c8fbb4 - Added `rescale_check` property to `PriorDict` class
    • 96454c32 - Added information
    • f3cb717e - Added check when setting rescale_check that object is in fact a `Prior`

    Compare with previous version

  • Moritz Huebner added 2 commits

    added 2 commits

    Compare with previous version

  • Moritz Huebner added 1 commit

    added 1 commit

    Compare with previous version

  • Moritz Huebner changed milestone to %0.6.5

    changed milestone to %0.6.5

  • added Priors label

  • Moritz Huebner added 1 commit

    added 1 commit

    • d1ea3b85 - Removed `check_range_nonzero` in favor of a more dynamic test

    Compare with previous version

  • Moritz Huebner changed the description

    changed the description

  • Moritz Huebner added 2 commits

    added 2 commits

    • ab9c9750 - Added test for non-zero range check
    • 2d248ed8 - Restructured cosmological prior minimum/maximum handling to be compatible when check ranges

    Compare with previous version

  • Moritz Huebner unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Moritz Huebner changed the description

    changed the description

  • Moritz Huebner added 1 commit

    added 1 commit

    • a03ed53f - extracted some redundant code

    Compare with previous version

  • Moritz Huebner added 1 commit

    added 1 commit

    • f82c36a8 - Fixed cosmological prior bound creation

    Compare with previous version

  • Moritz Huebner added 2 commits

    added 2 commits

    • e5bb7786 - Improved cosmological prior boundary logic
    • 8ccd07b2 - Reversed variable assignment order to prevent exception

    Compare with previous version

  • Moritz Huebner added 1 commit

    added 1 commit

    • 1cb4b330 - Fixed a minor bug that occurs if chirp mass is already in the CBCPriorDict

    Compare with previous version

  • Moritz Huebner marked as a Work In Progress

    marked as a Work In Progress

  • Gregory Ashton changed milestone to %0.6.4

    changed milestone to %0.6.4

  • Gregory Ashton changed milestone to %0.6.5

    changed milestone to %0.6.5

  • Gregory Ashton changed milestone to %0.6.6

    changed milestone to %0.6.6

  • Colm Talbot changed milestone to %0.6.7

    changed milestone to %0.6.7

  • changed milestone to %0.6.8

  • Moritz Huebner added 116 commits

    added 116 commits

    Compare with previous version

  • Moritz Huebner added 1 commit

    added 1 commit

    • 7592a25a - Fixed an issue that arose during merging

    Compare with previous version

  • Gregory Ashton changed milestone to %Future

    changed milestone to %Future

  • Please register or sign in to reply
    Loading