WIP: Prior clean up
Requires !688 (merged)
Some code improvements for the prior package:
- Cleaned up a bunch of warnings
- removed if/else-clauses for prob/rescale/ln_prob/cdf methods that distinguish between float and array input. It now always uses the array logic and then checks the type to return a float if it is a float input
- Introduced
@valid_rescale_check
and@consistent_type_use
decorators to reduce redundant code throughout the package - Restructured the prior tests into its own package
- Assured that prior saving/loading is still working the same way.
- Got rid off the
check_range_nonzero
argument in favour of dynamic testing with properties
Merge request reports
Activity
changed milestone to %1.0.0
added Refactoring label
added 1 commit
- 93ae62fc - Fixed inconsistent return of floats and arrays from rescale methods
added 10 commits
- 498c618e - Implemented a decorator to assure consistent use of float/arrays in the prior packages
- dc4560ca - Made use of a decorator to enforce consistent type use in priors
- 8219aff9 - Enforced more consistent type use
- 9816c21b - Enforced more consistent type use
- 4b39f5a6 - Made consistent type wrapper work with tests
- d8d232a4 - Added decorator to check valid rescaling
- da76f025 - Enforced Consistent use of arrays in all prob/ln_prob/recale/cdf methods
- 6b5a0389 - Made docstrings more consistent
- 4bbfa85e - Simplified some expressions
- 0e1090a5 - Fixed the rescale check decorator
Toggle commit listadded 2 commits
added 29 commits
-
5839387b...29a34a34 - 28 commits from branch
master
- 8c0da7bd - Merge remote-tracking branch 'origin/master' into prior_clean_up
-
5839387b...29a34a34 - 28 commits from branch
added 2 commits
- Automatically resolved by Moritz Huebner
- Automatically resolved by Moritz Huebner
added 9 commits
- dbbcddd4 - Removed Python 2 specific handling in repr test
- 4d05cdbd - Fixed a typo introduced when manually merging
- 03a6c405 - changed no_rescale_check -> rescale_check
- b52b861d - Simplified some expressions
- 2eb8eb91 - Made IS_FIXED a public class attribute
- 28288be5 - Added new prior feature information
- d1c8fbb4 - Added `rescale_check` property to `PriorDict` class
- 96454c32 - Added information
- f3cb717e - Added check when setting rescale_check that object is in fact a `Prior`
Toggle commit listadded 2 commits
changed milestone to %0.6.5
added Priors label
added 1 commit
- d1ea3b85 - Removed `check_range_nonzero` in favor of a more dynamic test
added 1 commit
- 1cb4b330 - Fixed a minor bug that occurs if chirp mass is already in the CBCPriorDict
changed milestone to %0.6.4
changed milestone to %0.6.5
changed milestone to %0.6.6
changed milestone to %0.6.7
changed milestone to %0.6.8
added 116 commits
-
1cb4b330...0140d1e7 - 115 commits from branch
master
- 7054599f - Merge remote-tracking branch 'origin/master' into prior_clean_up
-
1cb4b330...0140d1e7 - 115 commits from branch
changed milestone to %Future