Generalise comp mass conv (Resolve #436)

This MR resolves issue #436 (closed) by including the prior ratio weights as well as the Jacobian term for the function to resample posterior samples with priors defined in Chirp Mass / Mass Ratio to samples with Uniform priors in Component Masses.

added Priors label

This looks nice, Thanks for taking this on!

Just so we have it on record, would you mind adding a plot of mass_1 and mass_2 where you draw samples from some chirp mass/mass ratio prior that isn't uniform in those parameters and then do the conversion and plot again to demonstrate that this is working?

Also, it looks like there's a bunch of older commits showing up in this MR. Can you rebase to master? Hopefully that should make it clear which commits are relevant.

resolved all threads

added 1 commit

• 4e199b23 - fixed up some prior checking logic

Compare with previous version

added 22 commits

• 09941c7b - change convert to flat comp_mass prior to accept no Uniform in chirpmass/massratio priors
• cca8b955 - remove extra line
• 006205e5 - make weights calcuation numpy array like
• 23430a5a - try not using result class reweighting
• 9f46f8c1 - change convert to flat comp_mass prior to accept no Uniform in chirpmass/massratio priors
• 480925c2 - make weights calcuation numpy array like
• a4fa3165 - try not using result class reweighting
• 0370f623 - working on this issue still
• 204ff25b - make weights calcuation numpy array like
• f31c2bfb - try not using result class reweighting
• e8375b20 - change convert to flat comp_mass prior to accept no Uniform in chirpmass/massratio priors
• 8c3212be - make weights calcuation numpy array like
• f80ca13d - try not using result class reweighting
• dd537502 - working on this issue still
• 1e9435bc - generalise prior to flat comp mass conversion
• bbe84d13 - remove old commented out lines
• 1dc313d4 - formatting flake8
• 58a39b82 - rename some variables
• 4daa2632 - more clear commenting
• 42508bb6 - fixed up some prior checking logic
• 42fce58c - flake8
• aacdef7a - Merge branch 'generalise_comp_mass_conv' of...

Compare with previous version

closed