Resolve "Add multivariate gaussian to core likelihood"

Closes #455 (closed)

changed milestone to %0.6.5

added Example/Tutorial Refactoring labels

added 1 commit

• 1c9cf801 - Added multivariate gaussian to the core likelihood module

Compare with previous version

approved this merge request

@moritz.huebner this seems to be jamming a huge array into the likelihood. Can you instead just add the core functionality to the review script and then perhaps a test script which stores that array and tests it?

@gregory.ashton I am not entirely sure if I understand this question correctly. What would the review script exactly test then? And what do you mean by storing the array and testing it?

Is the problem that I added the review matrix to the core module? Should it instead live in the example file or in the review script?

Yes, I think not having the review matrix in the core module is a good idea. I'd suggest it live in a review script.

Basically, just have a single script which runs this test and passes (exits on sys.exit(0)) or fails (exits on sys.exit(1)) . It can live under tests/ if we want or examples, it doesn't really matter. Then, in the C.I. add a node which runs this test (or add it to one of the existing nodes)

changed milestone to %0.6.6

added 38 commits

• 1c9cf801...916d5c4e - 37 commits from branch master
• ab133708 - Merge remote-tracking branch 'origin/master' into 455-add-multivariate-gaussian-to-core-likelihood

Compare with previous version

added 6 commits

• ab133708...ce2a4047 - 2 commits from branch master
• e2288c6c - Merge remote-tracking branch 'origin/master' into 455-add-multivariate-gaussian-to-core-likelihood
• f0178ad6 - Added covariance matrix back to the script
• 218c6695 - Rearranged some stuff to make the diff smaller
• 3d580541 - Added unit tests to analytical likelihoods

Compare with previous version

@gregory.ashton @matthew-pitkin I will add the test of running the entire thing later. Right now I'm doing the evidence review in my own repo, but it should eventually become part of the bilby_pipe review script.

Can you approve this for now?

unmarked as a Work In Progress

approved this merge request

changed milestone to %0.6.7

changed milestone to %0.6.8

approved this merge request

mentioned in commit dc202662

merged