inconsistent_prior_files

Meant to close #490 (closed) . Basically just copy pasting the 2 existing binary_black_holes.prior files and add tides priors at the end. I started "fixing" @nicola.delillo 's file but then out of consistency it just seemed the more sensible thing to do.

Do we want a bunch of similar files for bns, nsbh etc or is that sufficient?

I am not exactly sure why the pipeline failed. I first thought it was because one of the automatic tests references the prior file: aligned_spins_waveform_tides_on.prior which I deleted/renamed in the MR: https://git.ligo.org/lscsoft/bilby/-/blob/master/test/gw_prior_test.py#L301 However I guess this lines calls prior files which are under test/prior_files/

A quick search in bilby shows that the file is also used as the default BNS prior file: https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/gw/prior.py#L520

So I guess I'll just put these files back in the MR.

mentioned in issue #490 (closed)

added 20 commits

• 8af5e284...ed8bef95 - 18 commits from branch lscsoft:master
• efc8076a - Merge branch 'master' of https://git.ligo.org/lscsoft/bilby into inconsistent_prior_files
• bcd258e8 - uniformization of the file names and modified these when called in other files

Compare with previous version

added 1 commit

• 7019f475 - Back to original default minimum value on bbh chirp_mass in priors: 25

Compare with previous version

approved this merge request

approved this merge request

@marc.arene thanks for doing this. I like the new consistency - we can expand in future to nsbh if needed, but this looks sufficient to me now.

mentioned in commit 9dd13d06

merged

changed milestone to %1.0.0