Tidy up of inject signal (!82) · Merge requests · lscsoft / bilby

Merged Gregory Ashton requested to merge tify-up-of-inject-signal into master 6 years ago

Jun 22, 2018
- Merge branch 'tify-up-of-inject-signal' of git.ligo.org:Monash/tupak into tify-up-of-inject-signal · 48dcbbc2
  Colm Talbot authored 6 years ago
  
  48dcbbc2
- update conversion to not remove search keys · a8f0f3f4
  Colm Talbot authored 6 years ago
  
  a8f0f3f4
Jun 21, 2018

Adds back in injection_polarization argument · 2cccc662

Gregory Ashton authored 6 years ago

- Provides backward compatibility for people with scripts using the old
  style
- Also because, as Colm pointed out, there may be bugger behaviour with
  multiple detectors and it may take a long time to calculate the waveform
- Change the name in `inject_signal` from
  waveform_polarizations->injection_polarizations.

This last step could break peoples code who are using inject_signal
directly, but its probably best to unify notation now rather than have
two names for one thing.

2cccc662

Revert "Track changes to inject_signal in a378ba9b to the examples" · e11ebac1
Gregory Ashton authored 6 years ago
```
This reverts commit 2ab4bddd.
```
e11ebac1

Fixes to get the tests to pass · 4c3a622b

Gregory Ashton authored 6 years ago

For some reason, the list comprehension method of setting the IFOs
intereacted badly with the example_test method. This doesn't change
anything, but just makes it a straightforward for loop.

Also removes the failing detector tests.

4c3a622b

Track changes to inject_signal in a378ba9b to the examples · 2ab4bddd
Gregory Ashton authored 6 years ago

2ab4bddd
Replace injection_polarizations with waveform_generator in inject signal · a378ba9b
Gregory Ashton authored 6 years ago
```
Closes #116
```
a378ba9b
Fix spacing of injection output · 594b4bae
Gregory Ashton authored 6 years ago

594b4bae
Fix tests for new raise ValueError · 68c51853
Gregory Ashton authored 6 years ago

68c51853

Tidy up of inject signal · 5409cd45

Gregory Ashton authored 6 years ago

- Changes the warning to an Error
- Adds method to InterferometerStrainData to check if a time is within
  the span
- Clean up logging of warning if the geocent_time is within the data
  span
- Print infomation about the injection to the terminal

Closes #115

5409cd45

Admin message

Tidy up of inject signal

Merge request reports

Activity