Skip to content
Snippets Groups Projects

Calibration marginalization using a discrete set of realizations

Merged Ethan Payne requested to merge (removed):calibration_marginalization into master

Implementation of the calibration-marginalized likelihood outlined in LIGO DCC document P2000294.

The code also includes a slight change to the distance marginalization function allowing for arrays of both optimal and matched filter signal-to-noise ratios.

An example of likelihood reweighting with the calibration-marginalized likelihood is included.

Note that this MR relies on !855 (merged) and !856 (merged) to work. Those must be merged first.

Edited by Ethan Payne

Merge request reports

Approved by

Merged by avatar (Apr 20, 2025 12:20am UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Colm Talbot
  • Thanks @ethan.payne I wonder if it makes sense to split this into two MRs, one with the calibration specific changes and one with the modification to the reweighting?

  • Ethan Payne mentioned in merge request !855 (merged)

    mentioned in merge request !855 (merged)

  • Ethan Payne added 1 commit

    added 1 commit

    Compare with previous version

  • Ethan Payne changed the description

    changed the description

  • Ethan Payne added 3 commits

    added 3 commits

    • ed6e3424 - added documentation for starting_index and number_of_response_curves
    • 5ab84268 - Moved calibration setup to separate function and fixed d_inner_h name
    • 0e13f7f0 - simplified calibration index calculation

    Compare with previous version

  • Ethan Payne added 1 commit

    added 1 commit

    • 4df824ef - calculating the inner product only for recalib_index if given

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 3 commits

    added 3 commits

    • 8159f787 - Moved B-spline distance marginalization to utils class, fixed some introduced bugs
    • 290979e7 - utilize the get_calibration_log_likelihoods function in...
    • b15512a8 - changed variable names

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    Compare with previous version

  • Thanks for the comments @colm.talbot! As per your suggestion, I've opened a MR for the reweighting changes (!856 (merged)) though I'm yet to remove them from this MR. It'd be best to merge the reweighting changes first anyway. I've also made a MR for the pyTables import to ensure that the CI pipeline doesn't fail.

    Edited by Ethan Payne
  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    • 12d2f5bf - Getting the time-calibration-marginalized likelihood working

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    • 4fda8e6b - Getting the time-calibration-marginalized likelihood working

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    • d9c68f9f - Getting the time-calibration-marginalized likelihood working

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    • a01f1352 - Getting the time-calibration-marginalized likelihood working

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    • e7b54654 - Getting the time-calibration-marginalized likelihood working

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit
  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit
  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    Compare with previous version

  • Ethan Payne resolved all threads

    resolved all threads

  • Ethan Payne added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading