Some changes to the results file for reweighting and uses of reweighted results

I've made some changes to some of the output saved from reweighting as well as updating some functions to calculate confidence intervals using weights.

mentioned in merge request !851 (merged)

changed title from Some changes to the results file and uses of reweighted results to Some changes to the results file for reweighting and uses of reweighted results

Hi @ethan.payne thanks for submitting this. I am bit concerned if this is the best way to implement these changes. You effectively add a bunch of new attributes to the result object that aren't used in 99% of all cases.

I think it would actually be better either:

1. reweight returns a new Result object that is different from the one you pass in instead of modifying the one the user provides. You'd have to return the efficiency and weights separately and you would get rid off old/new_log_likelihood/prior_array. These arrays still live in the individual results and can thus be accessed by the user.

2. You make reweight a method of Result. This would match more naturally with what you are trying to do here. old/new_log_likelihood/prior_array, weights, ... would be attributes that aren't available for the user to set during initialisation then but they would only be set when reweight is being run. Problem with that is that it breaks backwards compatibility with existing code, so I would be cautious implementing that.

added 2 commits

• c446c7d3 - changing how the reweighting results are stored/handled
• f77e00db - flake8

Compare with previous version

resolved all threads

In addition to the things above, there are a number of places where extra arguments are added without updating the docstrings. Please ensure the docstrings are updated.

changed milestone to %Future

changed milestone to %1.0.4

added Result/output label

added 1 commit

• 0df7c65c - Updated docstrings and removed conversion function within reweighting code

Compare with previous version

added 116 commits

• 0df7c65c...d5f739b5 - 114 commits from branch lscsoft:master
• 64edb2cb - Merge remote-tracking branch 'upstream/master'
• 00c0ab08 - Merge branch 'master' into reweighting-changes

Compare with previous version

Hey @gregory.ashton, I think the code is almost ready to be merged though it seems to be failing other (unrelated) tests which I am unsure on how to resolve...

mentioned in merge request !917 (merged)

added 10 commits

• 00c0ab08...762568df - 9 commits from branch lscsoft:master
• e10f3a34 - Merge remote-tracking branch 'upstream/master' into reweighting-changes

Compare with previous version

resolved all threads

mentioned in merge request !918 (closed)

changed milestone to %1.1.0

approved this merge request

resolved all threads

added 1 commit

• 50e9d429 - updating result prior dictionary when reweighting

Compare with previous version

resolved all threads

approved this merge request

resolved all threads

added 21 commits

• 50e9d429...bef3cfa5 - 20 commits from branch lscsoft:master
• 4d63c2c3 - Merge remote-tracking branch 'upstream/master' into reweighting-changes

Compare with previous version

approved this merge request

approved this merge request

resolved all threads

added 3 commits

• 4d63c2c3...54c90923 - 2 commits from branch lscsoft:master
• ce23e2b9 - Merge remote-tracking branch 'upstream/master' into reweighting-changes

Compare with previous version

approved this merge request

approved this merge request

merged

mentioned in commit 309158d6

mentioned in merge request !928 (merged)