modularise job creation code

• bilby_pipe.main is getting very large (>1000 lines of code) and has a lot going on
• this MR moves the condor/slurm job creation code into a separate module

If the above is considered a good idea, I am also happy to add docs to the new files that have been created.

marked as a Work In Progress

changed the description

added 1 commit

• eb2421e0 - add job creation package

Compare with previous version

added 1 commit

• 84447d73 - fix test calls to main

Compare with previous version

unmarked as a Work In Progress

added 1 commit

• bf68f593 - Update .gitignore

Compare with previous version

@avi.vajpeyi, I think this is a positive change.

It might be a good idea to keep copies of the moved classes in the main module with a deprecation warning, at least for a release or two.

ok sounds good!

FWIW, I'd be okay with not adding the deprecation warning. I don't think anyone is using bilby_pipe as an API or doing such an import. On the other hand, it is an extra thing to maintain (we eventually need to phase it out). So long as the CHANGELOG is clear, breaking changes are okay right now.

Woohoo! Fewer changes for me to make :)

I'd like to side with Greg on not adding the deprecation warning.

Are you ok with that @colm.talbot ?

Sure, I may have some projects that import bits of this code, but I can just deal with it.

Just as a heads up, I'm using the bilby_pipe API for generating Condor jobs in CWInPy. I've updated CWInPy to account for these changes.

resolved all threads

added 1 commit

• 5d845b16 - Update overview.py

Compare with previous version

mentioned in issue bilby#509 (closed)

approved this merge request

resolved all threads

merged

mentioned in commit ade6e0b1

changed the description

changed milestone to %1.0.1