XML Converter Update: geocent_time (!407) · Merge requests · lscsoft / bilby_pipe · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.

Merged Joshua Brandt requested to merge joshua.brandt/bilby_pipe:xml-converter-update into master 3 years ago

The XML converter did not add the decimal to geocent_time, as the full time is split between integer(geocent_end_time) and float (geocent_end_time_ns) in the XML file. Added term to include float component to integer component when converting.

The early commits are adjusting (only adjusting one line), the rest were trying to fix the spacing issue.

Issue: #218 (closed)

Edited 3 years ago by Joshua Brandt

Activity

Joshua Brandt changed the description 3 years ago

changed the description
Gregory Ashton approved this merge request 3 years ago

approved this merge request
Gregory Ashton @gregory.ashton · 3 years ago

Maintainer

Hi @joshua.brandt this looks good to me. Thanks for the MR. I've approved and will merge. Ideally, this sort of issue should be caught by a test, perhaps something we can look at in the future.

Edited 3 years ago by Gregory Ashton
Gregory Ashton merged 3 years ago

merged
Gregory Ashton mentioned in commit fbcd3c16 3 years ago

mentioned in commit fbcd3c16
Gregory Ashton changed milestone to %1.0.5 3 years ago

changed milestone to %1.0.5

Please register or sign in to reply