Skip to content
Snippets Groups Projects
Commit ac4d0d75 authored by Kipp Cannon's avatar Kipp Cannon
Browse files

gstlal, gstlal-burst, gstlal-inspiral: fix .pc files

- this mostly reverts the rest of 70c88cd6
  "use private fields in pkgconfig files"
- the requirements of each of the gstlal libraries are not private, it is
  through these dependencies that the correct -I options are added when
  compiling things that #include the header files.  NOTE:  the header files
  in, for example, gstlal #include header files from other
  projects, header files that are not, in general, located in the default
  search paths of compilers.  pkg-config is required to determine the
  complete set of -I options, it does so using the "requires" field.
- 70c88cd6 "use private fields in pkgconfig
  files" didn't break gstlal builds because the gstlal packages,
  themselves, tend to have the same internal requirements as the exported
  requirements of other gstlal packages.  for example, using gstlal's
  header files requires you to add the -I options necessary to find all the
  gstreamer headers, which everything in gstlal-inspiral needs to add
  anyway, for its own reasons, so breaking gstlal's .pc file didn't break
  the gstlal-inspiral build.  it *does* break builds of other stuff,
  outside of these projects, that might try to link to gstlal but isn't a
  gstreamer based project itself.
- what this patch does do, is conduct an audit of what things are really
  #include'd in installed header files and only lists those things in the
  requires field instead of all libraries the project links against.
parent 678e6954
No related branches found
No related tags found
No related merge requests found
Pipeline #88437 passed with warnings
......@@ -6,6 +6,6 @@ includedir=@includedir@
Name: libgstlalburst
Description: LAL/Gstreamer Library (the bursty bits)
Version: @VERSION@
Requires.private: lal lalmetaio lalburst gstlal
Requires: lal lalmetaio glib-2.0 gsl gstlal
Libs: -L${libdir} -lgstlalburst
Cflags: -I${includedir}
......@@ -6,6 +6,6 @@ includedir=@includedir@
Name: libgstlalinspiral
Description: LAL/Gstreamer Library (the inspiral bits)
Version: @VERSION@
Requires: gstlal
Requires: glib-2.0 gsl gstlal gstreamer-@GSTREAMER_RELEASE@ lal lalmetaio
Libs: -L${libdir} -lgstlalinspiral
Cflags: -I${includedir}
......@@ -6,6 +6,6 @@ includedir=@includedir@
Name: libgstlal
Description: LAL/Gstreamer Library
Version: @VERSION@
Requires.private: fftw3 gsl lal lalframe lalmetaio lalsupport lalburst gstreamer-@GSTREAMER_RELEASE@ gstreamer-base-@GSTREAMER_RELEASE@ gstreamer-audio-@GSTREAMER_RELEASE@ gstreamer-video-@GSTREAMER_RELEASE@ gstreamer-plugins-base-@GSTREAMER_RELEASE@
Requires: glib-2.0 gsl gstreamer-@GSTREAMER_RELEASE@ gstreamer-audio-@GSTREAMER_RELEASE@ lal
Libs: -L${libdir} -lgstlal -lgstlaltags -lgstlaltypes
Cflags: -I${includedir}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment