- this mostly reverts the rest of 70c88cd6
  "use private fields in pkgconfig files"
- the requirements of each of the gstlal libraries are not private, it is
  through these dependencies that the correct -I options are added when
  compiling things that #include the header files.  NOTE:  the header files
  in, for example, gstlal #include header files from other
  projects, header files that are not, in general, located in the default
  search paths of compilers.  pkg-config is required to determine the
  complete set of -I options, it does so using the "requires" field.
- 70c88cd6 "use private fields in pkgconfig
  files" didn't break gstlal builds because the gstlal packages,
  themselves, tend to have the same internal requirements as the exported
  requirements of other gstlal packages.  for example, using gstlal's
  header files requires you to add the -I options necessary to find all the
  gstreamer headers, which everything in gstlal-inspiral needs to add
  anyway, for its own reasons, so breaking gstlal's .pc file didn't break
  the gstlal-inspiral build.  it *does* break builds of other stuff,
  outside of these projects, that might try to link to gstlal but isn't a
  gstreamer based project itself.
- what this patch does do, is conduct an audit of what things are really
  #include'd in installed header files and only lists those things in the
  requires field instead of all libraries the project links against.

- this fixes a maintainance problem introduced by 70c88cd6 "use private fields in pkgconfig files"

- fix DAG.__init__() for Python 2.
- also clean up some cruft.

chad.hanna authored 5 years ago and Patrick Godwin committed 5 years ago

gstlal_inspiral_svd_bank_pipe: add --autocorrelation-length option to set AC length for a given chirp mass range, can be specified multiple times

This reverts commit 4ee78ca7.

- that patch had a number of problems:  (i) it is inappropriate for the writing routine to have the side effect of altering the graph structure, this breaks the primary use case of editing existing DAGs, wherein one loads a DAG and then write back to disk the *same* DAG;  (ii) the particular change that was introduced requires the resulting DAG to have an extra submit file that is not provided, resulting in DAGs that cannot be run;  (iii) the code would insert no-op jobs even between a single parent and its children or an only child and its parents if there are more children or parents than some threshold, increasing the size of the DAG (the opposite of what this is supposed to be doing), and because the transformation is embedded in the writing code the expansion would be repeated every time the DAG is processed;  (iv) the problem this is trying to fix is not in this code at all but in the inspiral DAG construction script, which is creating bloated parent-child relationships and is where this fix, if desired, should have been made.
- assuming one actually wants a tool to do this to DAGs, say, instead of fixing the programs that generate the bloated DAGs, the correct solution is to write a separate utility to implement the transformation, and not embed it in the writing code.  this patch provides that tool.  it is left as an exercise to others to modify their clean-up programs to make use of the tool, but, again, just fix the DAG generator.

- move "initialize from existing object" code from .select_nodes_by_name() to .__init__() for general re-use

- avoid attribute look-ups in the arc processing loop

- allows large dag graphs to be written to dot files without having to
  store the entire text in ram.

- remove python-glue-ligolw-tools

- of gstlal/gstlal_peakfinder.h

- this needs gsl/gsl_matrix_complex_float.h

httpinterface.py: turn off service discovery if avahi is not available, remove ref to servicediscovery in gstlal_inspiral

change --sub-bank-id to --bank-number to avoid confusion with bank_id;
clarify --save options;
remove __epilog__ from --help output.

gstlal_inspiral_plotsummary: modify event table columns to consolidate template properties, add UTC time column

gstlal_inspiral_activation_counts_dag: add --condor-command option, standard condor opts to job, rename bin to avoid conflict

                Restrict sampler in chi2/snr2 to sample from 1e-5 to 1e20

(cherry picked from commit 0f170745)

gstlal_inspiral_mass_model: Change ligo BBH peak to 30 and alpha for ligo BBH to -2.

See merge request !14

(cherry picked from commit d275c280)

(cherry picked from commit bb93fd80)

gstlal_inspiral_mass_model : syncing up branches. Include template density, remove detected-logm model, other tweaks.

chad.hanna authored 5 years ago and Chad Hanna committed 5 years ago

(cherry picked from commit 82cac97e)