Skip to content
Snippets Groups Projects
  1. Nov 12, 2019
  2. Nov 11, 2019
    • Kipp Cannon's avatar
      Revert "Add explicit synchronization point." · 115f58ed
      Kipp Cannon authored
      This reverts commit 4ee78ca7.
      
      - that patch had a number of problems:  (i) it is inappropriate for the writing routine to have the side effect of altering the graph structure, this breaks the primary use case of editing existing DAGs, wherein one loads a DAG and then write back to disk the *same* DAG;  (ii) the particular change that was introduced requires the resulting DAG to have an extra submit file that is not provided, resulting in DAGs that cannot be run;  (iii) the code would insert no-op jobs even between a single parent and its children or an only child and its parents if there are more children or parents than some threshold, increasing the size of the DAG (the opposite of what this is supposed to be doing), and because the transformation is embedded in the writing code the expansion would be repeated every time the DAG is processed;  (iv) the problem this is trying to fix is not in this code at all but in the inspiral DAG construction script, which is creating bloated parent-child relationships and is where this fix, if desired, should have been made.
      - assuming one actually wants a tool to do this to DAGs, say, instead of fixing the programs that generate the bloated DAGs, the correct solution is to write a separate utility to implement the transformation, and not embed it in the writing code.  this patch provides that tool.  it is left as an exercise to others to modify their clean-up programs to make use of the tool, but, again, just fix the DAG generator.
      115f58ed
    • Kipp Cannon's avatar
      dagfile.DAG: · df4240cd
      Kipp Cannon authored
      - move "initialize from existing object" code from .select_nodes_by_name() to .__init__() for general re-use
      df4240cd
    • Kipp Cannon's avatar
      dagfile: parsing performance improvement · 254490a6
      Kipp Cannon authored
      - avoid attribute look-ups in the arc processing loop
      254490a6
    • Kipp Cannon's avatar
      dagfile: convert .dot_source() to generator · 080de161
      Kipp Cannon authored
      - allows large dag graphs to be written to dot files without having to
        store the entire text in ram.
      080de161
    • Kipp Cannon's avatar
      gstlal-ugly gstlal-inspiral: update Build-Depends · c2106f12
      Kipp Cannon authored
      - remove python-glue-ligolw-tools
      c2106f12
    • ChiWai Chan's avatar
      gstlal_snglinspiral.h: add missing #include · b04b9440
      ChiWai Chan authored
      - of gstlal/gstlal_peakfinder.h
      b04b9440
    • ChiWai Chan's avatar
      gstlal_snglinspiral.h: add missing header file · 1d8cd6f7
      ChiWai Chan authored
      - this needs gsl/gsl_matrix_complex_float.h
      1d8cd6f7
  3. Nov 07, 2019
  4. Nov 05, 2019
  5. Nov 03, 2019
  6. Nov 02, 2019
  7. Nov 01, 2019
  8. Oct 28, 2019
  9. Oct 25, 2019
  10. Oct 24, 2019
  11. Oct 22, 2019
  12. Oct 21, 2019
Loading