Bug fix for injection filtering when only injection file is provided as input instead of injection frames.

Previously implemented logic in inspiral.py and gstlal_inspiral for analyzing injection frames set the injection file to None when the user provided only the injection-file, making the code non-backward compatible.

• This MR adds an extra flag --inject-in-noise as an option in gstlal_inspiral which tells the job to use the injection-file to make the injection in h(t).
• This flag should only be used when the datasource is a data-find-server or a frame-cache pointing to detector noise i.e. when injection-frame-cache is not specified in the configuration file config.yml.

Test runs:

• with --inject-in-noise : https://ldas-jobs.ligo.caltech.edu/~divya.singh/observing/4/dev/offline-inj_frames/fix_injfile_test/injection_recovery.html
• with noiseless frames : https://ldas-jobs.ligo.caltech.edu/~divya.singh/observing/4/dev/offline-inj_frames/fix_injfile_test_frames/injection_recovery.html

Rundir on CIT: /home/divya.singh/observing/4/dev/offline-inj_frames/fix_injfile_test

requested review from @rachael.huxford and @prathamesh.joshi

assigned to @divya.singh

The logic looks good to me, but I do worry that the combination of options required for whatever type of injections you have is a bit difficult to understand.

Can I suggest something different? I think there are 3 ways to specify the source of injections:

1. noiseless inj frames
2. noisy inj frames
3. injection file + dynamically injecting them into h(t)

Maybe instead of the --injections flag, we could have an --injection-type argument, with the three options above being allowed inputs, and None/not specifying that argument denoting it's not an inj job. And then the rest of the arguments like --injection-file, etc could just be common to all types. This way probably the logic for both specifying the options, and for checking their validity would be easier.

But since I'm not too familiar with the inj workflow, I'm not sure if this is a valid option.

added 63 commits

• 7de6a89c...f7baa119 - 61 commits from branch offline_new-workflow
• a60209a4 - add extra flag in gstlal_inspiral to tell job to make injection in detector...
• 6182fa16 - add logic for source options when injectin frame cache is not provided with injection file.

Compare with previous version

added 1 commit

• 5cf21878 - fix the elif statement for datafindserver case

Compare with previous version

changed the description

resolved all threads