Bug fix for injection filtering when only injection file is provided as input instead of injection frames.

Previously implemented logic in inspiral.py and gstlal_inspiral for analyzing injection frames set the injection file to None when the user provided only the injection-file, making the code non-backward compatible.

• This MR adds an extra flag --inject-in-noise as an option in gstlal_inspiral which tells the job to use the injection-file to make the injection in h(t).
• This flag should only be used when the datasource is a data-find-server or a frame-cache pointing to detector noise i.e. when injection-frame-cache is not specified in the configuration file config.yml.

Test runs:

• with --inject-in-noise : https://ldas-jobs.ligo.caltech.edu/~divya.singh/observing/4/dev/offline-inj_frames/fix_injfile_test/injection_recovery.html
• with noiseless frames : https://ldas-jobs.ligo.caltech.edu/~divya.singh/observing/4/dev/offline-inj_frames/fix_injfile_test_frames/injection_recovery.html

Rundir on CIT: /home/divya.singh/observing/4/dev/offline-inj_frames/fix_injfile_test

gstlal-inspiral/python/dags/layers/inspiral.py

@@ -558,11 +558,15 @@ def filter_injections_layer(config, dag, ref_psd_cache, svd_bank_cache):
 		elif config.source.inj_frame_cache and not config.injections.filter[inj_type]["noiseless_inj_frames"]:
 			inputs.append(Option("frame-cache", config.source.inj_frame_cache, track=False))
 			filter_opts.append(Option("channel-name", dagutil.format_ifo_args(ifos, config.source.inj_channel_name)))
-		elif config.source.frame_cache and not config.source.inj_frame_cache:
+		elif config.source.frame_cache and not config.source.inj_frame_cache and not config.injections.filter[inj_type.lower()]["noiseless_inj_frames"]:
 			inputs.append(Option("frame-cache", config.source.frame_cache, track=False))
-			filter_opts.append(Option("channel-name", dagutil.format_ifo_args(ifos, config.source.channel_name)))
-		else:
 			filter_opts.extend([
+				Option("inject-in-noise"),
+				Option("channel-name", dagutil.format_ifo_args(ifos, config.source.channel_name))
+			])
+		elif config.source.data_find_server and not (config.source.frame_cache or config.source.inj_frame_cache) and not config.injections.filter[inj_type.lower()]["noiseless_inj_frames"]:
+			filter_opts.extend([
+				Option("inject-in-noise"),
 				Option("frame-type", dagutil.format_ifo_args(ifos, config.source.frame_type)),
 				Option("data-find-server", config.source.data_find_server),
 				Option("channel-name", dagutil.format_ifo_args(ifos, config.source.channel_name)),