No embedded python in pip install lalsuite

Hi @duncanmmacleod,

When installing lalsuite through pip install I cannot use the new waveforms interface to call my own external python model.

Looking at the code it seems that the variable HAVE_PYTHON3_EMBED here is not defined, because I get the error message "Python generator not implemented" in line 18.

Probably when the python wheels are created for pypi one needs to switch on an option to compile with embedded python?

Could you have a look? Thanks!

@cecilio.garcia-quiros, can you post enough code to reproduce the error, starting from pip install lalsuite?

added lalsimulation pkg_wheel platformbest effort priorityshouldfix labels

Yes @duncanmmacleod, sorry.

• I created a fresh conda env with only python=3.10.
• Then pip install lalsuite
• Then run the following code

import lalsimulation as lalsim
import lal

lal_dict = lal.CreateDict()
lal_approximant = lalsim.ExternalPython

lal.DictInsertStringValue(lal_dict, "module", 'random_module')
lal.DictInsertStringValue(lal_dict, "object", 'random_object')

generator = lalsim.SimInspiralChooseGenerator(lal_approximant, lal_dict)

hp, hc = lalsim.SimInspiralGenerateFDWaveform(lal_dict, generator)

What gives the error

XLAL Error - initialize (LALSimInspiralGeneratorPython.c:18): Python generator not implemented
XLAL Error - initialize (LALSimInspiralGeneratorPython.c:18): Invalid argument
XLAL Error - XLALCreateSimInspiralGenerator (LALSimInspiral.c:426): Internal function call failed: Invalid argument
Traceback (most recent call last):
  File "/home/cecilio/Projects/NewInterface/test.py", line 10, in <module>
    generator = lalsim.SimInspiralChooseGenerator(lal_approximant, lal_dict)
RuntimeError: Internal function call failed: Invalid argument

And what should happen in this case?

Since "random_module" and "random_object" do not exist, it should give this error:

XLAL Error - initialize (../../../../git/lalsuite/lalsimulation/lib/LALSimInspiralGeneratorPython.c:707): Could not find module random_module
XLAL Error - initialize (../../../../git/lalsuite/lalsimulation/lib/LALSimInspiralGeneratorPython.c:707): Generic failure
XLAL Error - python_error (../../../../git/lalsuite/lalsimulation/lib/LALSimInspiralGeneratorPython.c:88): Python exception raised
ModuleNotFoundError: No module named 'random_module'
XLAL Error - XLALCreateSimInspiralGenerator (../../../../git/lalsuite/lalsimulation/lib/LALSimInspiral.c:426): Internal function call failed: Generic failure

Is there a way to 'test' that the system works, without installing third-party modules?

If you get the above message when installing with pip I would already consider that it works, because it would mean that the variable HAVE_PYTHON3_EMBED is True and that it has compiled the GeneratorPython part (i.e. the part beyond line 32 in LALSimInspiralGeneratorPython.c). Currently it only compiles the part from line 9 to 31.

If you really want to generate some waveform, give me a few minutes and I will give an example.

mentioned in merge request !2229 (closed)

Sorry, I am having problems getting a working example. I have seen the fixes for the manylinux wheels, that's great. There should be something similar for macOS? This problem also appears in macs.

Here there is a very minimal working example. Saving the two files together and doing python test.py should work.

mymodel.py

test.py

mentioned in issue #677 (closed)

marked #677 (closed) as a duplicate of this issue

marked this issue as related to #677 (closed)

mentioned in merge request !2243 (merged)

marked this issue as blocked by lalsuite-manylinux#3 (closed)

@cecilio.garcia-quiros, !2243 (merged) fixes the first build problem that should result in the macOS wheels including the embedded Python support.

However the Linux wheels are still a separate problem. This is discussed on lalsuite-manylinux#3 (closed).

mentioned in merge request !2244

Hi @duncanmmacleod, I am seeing the issue above also using recent igwn environments (starting from igwn-py310-20240514), while this used to work for previous environments up to igwn-py310-20240410. Do you what could be the reason of this change? Thank you.

There is a 'bug' in the tarball that impacts the conda builds. I will patch it.

mentioned in issue #746