Skip to content

Draft: Compile liblalsimulation against libpython3.X.a for manylinux wheels

Duncan Macleod requested to merge duncanmmacleod/lalsuite:ci-wheel-lalsim-embed into master

Description

This MR closes lalsuite-manylinux#3 (closed) by unpacking the compressed libpython3.X.a static libraries before compiling lalsuite for the wheels. This enables the liblalsimulation.so build to link against libpython3 (statically) to support the embedded Python waveform generator.

This properly fixes #722.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports