Description
This patch adds test_waveform_generation.py to /lalsimulation/test/python, which attempts to generate a waveform for every approximant using one or more of the XLALSimInspiralTD, XLALSimInspiralFD, XLALSimInspiralChooseTDWaveform, and XLALSimInspiralChooseFDWaveform.
The approximants are handled in parametrised groups, the idea being to sanity check the code by generating a non-zero waveform, and not test much else. All tests run with zero spin, and zero eccentricity, with the following exceptions:
-
HGImrihass1z = 0.6 -
EccentricFDandEccentricTDhaveecc = 0.1
Additionally, because the CI doesn't have access to lalsuite-extra, or lvcnr-lfs, approximants requiring external data are skipped.
ATOW, the following cases are failing:
| Approximant | Function(s) | m1,m2 | Error |
|---|---|---|---|
HGimri |
SimInspiralFD |
40,4 | XLAL Error: Radius is negative or NaN. Failed to complete 10 steps inside light ring. Use smaller time step dt. Halting FINALPLUNGE. |
IMRPhenomC |
SimInspiralChooseTDWaveform, SImInspiralTD
|
10,10 | XLAL Error - IMRPhenomCGenerateFDForTD (LALSimIMRPhenomC.c:456): The required length passed as input wont fit the FD waveform |
PhenSpinTaylor |
SimInspiralChooseTDWaveform, SimInspiralTD, SimInspiralFD
|
10,10 | Segmentation fault |
PhenSpinTaylorRD |
SimInspiralChooseTDWaveform, SimInspiralTD, SimInspiralFD
|
10,10 | Segmentation fault |
SpinTaylorF2 |
SimInspiralTD, SimInspiralChooseFDWaveform, SimInspiralFD
|
10,10 |
abs(hp + hc) is identically zero |
SpinTaylorT4Fourier |
SimInspiralChooseFDWaveform, SimInspiralTD, SimInspiralFD
|
10,10 | XLAL Error - XLALSimInspiralSpinTaylorDriverFourier: spline interpolation returned with error code 4 |
SpinTaylorT5Fourier |
SimInspiralTD |
10,10 | Segmentation fault |
SpinTaylorT5Fourier |
SimInspiralChooseFDWaveform, SimInspiralFD
|
10,10 | XLAL Error - XLALSimInspiralSpinTaylorDriverFourier: spline interpolation returned with error code 4 |
TaylorT3 |
SimInspiralChooseTDWaveform |
1.4,1.4 | XLAL Error - XLALSimInspiralTofV (LALSimInspiralTaylorLength.c:127): Internal function call failed |
I am happy to be told that the input parameters are wrong for one or more of these tests.
API Changes and Justification
Backwards Compatible Changes
-
This change introduces no API changes -
This change adds new API calls
Backwards Incompatible Changes
-
This change modifies an existing API -
This change removes an existing API
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
Review Status
Please provide details on any reviews related to this change and and the associated reviewers.