Add lalsimulation waveform-generation python tests
Description
This patch adds test_waveform_generation.py
to /lalsimulation/test/python
, which attempts to generate a waveform for every approximant using one or more of the XLALSimInspiralTD
, XLALSimInspiralFD
, XLALSimInspiralChooseTDWaveform
, and XLALSimInspiralChooseFDWaveform
.
The approximants are handled in parametrised groups, the idea being to sanity check the code by generating a non-zero waveform, and not test much else. All tests run with zero spin, and zero eccentricity, with the following exceptions:
-
HGImri
hass1z = 0.6
-
EccentricFD
andEccentricTD
haveecc = 0.1
Additionally, because the CI doesn't have access to lalsuite-extra, or lvcnr-lfs, approximants requiring external data are skipped.
ATOW, the following cases are failing:
Approximant | Function(s) | m1,m2 | Error |
---|---|---|---|
HGimri |
SimInspiralFD |
40,4 | XLAL Error: Radius is negative or NaN. Failed to complete 10 steps inside light ring. Use smaller time step dt. Halting FINALPLUNGE. |
IMRPhenomC |
SimInspiralChooseTDWaveform , SImInspiralTD
|
10,10 | XLAL Error - IMRPhenomCGenerateFDForTD (LALSimIMRPhenomC.c:456): The required length passed as input wont fit the FD waveform |
PhenSpinTaylor |
SimInspiralChooseTDWaveform , SimInspiralTD , SimInspiralFD
|
10,10 | Segmentation fault |
PhenSpinTaylorRD |
SimInspiralChooseTDWaveform , SimInspiralTD , SimInspiralFD
|
10,10 | Segmentation fault |
SpinTaylorF2 |
SimInspiralTD , SimInspiralChooseFDWaveform , SimInspiralFD
|
10,10 |
abs(hp + hc) is identically zero |
SpinTaylorT4Fourier |
SimInspiralChooseFDWaveform , SimInspiralTD , SimInspiralFD
|
10,10 | XLAL Error - XLALSimInspiralSpinTaylorDriverFourier: spline interpolation returned with error code 4 |
SpinTaylorT5Fourier |
SimInspiralTD |
10,10 | Segmentation fault |
SpinTaylorT5Fourier |
SimInspiralChooseFDWaveform , SimInspiralFD
|
10,10 | XLAL Error - XLALSimInspiralSpinTaylorDriverFourier: spline interpolation returned with error code 4 |
TaylorT3 |
SimInspiralChooseTDWaveform |
1.4,1.4 | XLAL Error - XLALSimInspiralTofV (LALSimInspiralTaylorLength.c:127): Internal function call failed |
I am happy to be told that the input parameters are wrong for one or more of these tests.
API Changes and Justification
Backwards Compatible Changes
-
This change introduces no API changes -
This change adds new API calls
Backwards Incompatible Changes
-
This change modifies an existing API -
This change removes an existing API
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
Review Status
Please provide details on any reviews related to this change and and the associated reviewers.
Merge request reports
Activity
added lalsimulation lang_python labels
added 1 commit
- aadedac4 - lalsimulation: set f_ref=0. for waveform gen tests
added infra_general pkg_general + 1 deleted label
assigned to @sebastian-khan
mentioned in merge request !1175 (merged)
added 570 commits
-
aadedac4...6d917955 - 565 commits from branch
lscsoft:master
- 5285cf6b - lalsimulation: add python waveform generation tests
- c30a6a58 - lalsimulation: run waveform generation tests in conda
- ff51154a - lalsimulation: update waveform tests
- 46150aab - lalsimulation: set f_ref=0. for waveform gen tests
- 6bd9abb9 - lalsimulation: improve waveform generation test
Toggle commit list-
aadedac4...6d917955 - 565 commits from branch
added 1711 commits
-
6bd9abb9...a217ea96 - 1707 commits from branch
lscsoft:master
- bf9b8581 - lalsimulation: add python waveform generation tests
- 2605fa31 - lalsimulation: update waveform tests
- b1825ed4 - lalsimulation: set f_ref=0. for waveform gen tests
- 8f74e224 - lalsimulation: improve waveform generation test
Toggle commit list-
6bd9abb9...a217ea96 - 1707 commits from branch
added 1 commit
- 196e1191 - lalsimulation: update test suite to get things to pass
added 24 commits
-
196e1191...c6d00e79 - 18 commits from branch
lscsoft:master
- a936c660 - lalsimulation: add python waveform generation tests
- ff2d0256 - lalsimulation: update waveform tests
- 7a167378 - lalsimulation: set f_ref=0. for waveform gen tests
- 464370ad - lalsimulation: improve waveform generation test
- ac20cfa2 - lalsimulation: update waveformgen test
- 2a05afd4 - lalsimulation: update test suite to get things to pass
Toggle commit list-
196e1191...c6d00e79 - 18 commits from branch
added 1 commit
- 8dfc4756 - lalsimulation: patch waveform-gen test to handle old pytest
added 1 commit
- b7c5d41e - lalsimulation: don't run waveform tests on python2
added 33 commits
-
119e543f...93c82478 - 23 commits from branch
lscsoft:master
- dd9f8f7e - lalsimulation: add python waveform generation tests
- f45694cd - lalsimulation: update waveform tests
- 381d0cdc - lalsimulation: set f_ref=0. for waveform gen tests
- 90ba333f - lalsimulation: improve waveform generation test
- 06b58bad - lalsimulation: update waveformgen test
- 1c5f7fcf - lalsimulation: update test suite to get things to pass
- e3a94e16 - lalsimulation: patch waveform-gen test to handle old pytest
- 83505298 - lalsimulation: don't run waveform tests on python2
- 7ebc8edc - lalsimulation: update XFAIL
- c26d2aa2 - lalsimulation: test TEOBResumS at high mass only
Toggle commit list-
119e543f...93c82478 - 23 commits from branch
removed pkg_general label
removed infra_general label
- A deleted user
removed lang_python label