Skip to content

Resolve "lalinference.imrtgr.imrtgrutils.calc_final_mass_spin failing on master"

David Keitel requested to merge david-keitel/lalsuite:fix-262-lalinference-imrtgr-imrtgrutils-calc_final_mass_spin-failing-on-master into master

Description

This should fix #262 (closed) where bbh_average_fits_precessing() fails when called with scalar inputs. All the lower-level fit functions called by this wrapper through _return_quantity() already do proper vectorizing, so the single sanity check line that is changed in this MR should be the only bit that needs a fix.

Supersedes !1214 (closed) now coming from my own fork, which hopefully makes this approvable.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

In !1214 (closed) this was already approved by @nathan-johnson-mcdaniel and the original bug reporter @aditya.vijaykumar also confirmed that this works.

Closes #262 (closed)

Merge request reports