Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 106
    • Issues 106
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 26
    • Merge Requests 26
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1272

Merged
Opened Mar 24, 2020 by Cecilio Garcia-Quiros@cecilio.garcia-quirosContributor1 of 4 tasks completed1/4 tasks

Add IMRPhenomXP and IMRPhenomXPHM reviewed models

  • Overview 141
  • Commits 255
  • Changes 32

Description

Add two new CBC precessing models: IMRPhenomXP (twisting of IMRPhenomXAS) and IMRPhenomXPHM (twisting of IMRPhenomXHM). Waveform review is complete.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Waveform review signed off by @maria.haney. Review statement: https://git.ligo.org/waveforms/reviews/imrphenomx/-/wikis/home#stage-2-review-sign-off-for-precessing-models

Edited Apr 01, 2020 by Maria Haney
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: lscsoft/lalsuite!1272
Source branch: imrphenomxphm-review

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.