Skip to content

Add IMRPhenomXP and IMRPhenomXPHM reviewed models

Cecilio Garcia-Quiros requested to merge waveforms/reviews/lalsuite:imrphenomxphm-review into master

Description

Add two new CBC precessing models: IMRPhenomXP (twisting of IMRPhenomXAS) and IMRPhenomXPHM (twisting of IMRPhenomXHM). Waveform review is complete.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Waveform review signed off by @maria.haney. Review statement: https://git.ligo.org/waveforms/reviews/imrphenomx/-/wikis/home#stage-2-review-sign-off-for-precessing-models

Edited by Ghost User

Merge request reports