Skip to content

PhenomPCore function modified for quadparam_1 and quadparam_2

NV KRISHNENDU requested to merge nv.krishnendu/lalsuite:master into master

Description

This is a modification to the PhenomPCore() inside lalsimulation/lib/LALSimIMRPhenomP.c . Currently, PhenomPCore assuems m2>m1 (and chi_1l < chi_2l) if m2 < m1 (and chi_1l < chi_2l) passed, internally swaps this to m2>m1 (and chi_1l < chi_2l). In the current way of initiazing the spin-induced quadrupole moment parameters, quadparam_1 and quadparam_2, this is not taken care of properly. This commit is to appropriately modify the PhenomPCore() function so that inside PhenomPCore(), quadparam_2>quadparam_2 is assured.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Duncan Macleod

Merge request reports