PhenomPCore function modified for quadparam_1 and quadparam_2
Compare changes
This is a modification to the PhenomPCore()
inside lalsimulation/lib/LALSimIMRPhenomP.c
. Currently, PhenomPCore assuems m2>m1 (and chi_1l < chi_2l) if m2 < m1 (and chi_1l < chi_2l) passed, internally swaps this to m2>m1 (and chi_1l < chi_2l). In the current way of initiazing the spin-induced quadrupole moment parameters, quadparam_1 and quadparam_2, this is not taken care of properly. This commit is to appropriately modify the PhenomPCore()
function so that inside PhenomPCore()
, quadparam_2>quadparam_2 is assured.
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
Please provide details on any reviews related to this change and and the associated reviewers.