Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
L
lalsuite
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 108
    • Issues 108
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 28
    • Merge Requests 28
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuite
  • Merge Requests
  • !1427

Merged
Opened Aug 23, 2020 by Nathan K. Johnson-McDaniel@nathan-johnson-mcdanielContributor1 of 4 tasks completed1/4 tasks

Add test for completeness of waveform list functions in LALSimulation

  • Overview 17
  • Commits 8
  • Pipelines 4
  • Changes 2

Description

Add a Python test to check that XLALSimInspiralGetSpinSupportFromApproximant(), XLALSimInspiralGetSpinFreqFromApproximant(), and XLALSimInspiralApproximantAcceptTestGRParams() are not missing entries for any waveforms implemented in LALSimulation. This test passes with the current version of LALSimInspiral.c and fails appropriately when waveform entries are removed from those functions--see here.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This has not been reviewed: @sebastian-khan is a possible reviewer

Edited Aug 28, 2020 by Nathan K. Johnson-McDaniel
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: lscsoft/lalsuite!1427
Source branch: test_wf_property_lists