Skip to content

Add test for completeness of waveform list functions in LALSimulation

Nathan Johnson-McDaniel requested to merge nathan-johnson-mcdaniel/lalsuite:test_wf_property_lists into master

Description

Add a Python test to check that XLALSimInspiralGetSpinSupportFromApproximant(), XLALSimInspiralGetSpinFreqFromApproximant(), and XLALSimInspiralApproximantAcceptTestGRParams() are not missing entries for any waveforms implemented in LALSimulation. This test passes with the current version of LALSimInspiral.c and fails appropriately when waveform entries are removed from those functions--see here.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This has not been reviewed: @sebastian-khan is a possible reviewer

Edited by Nathan Johnson-McDaniel

Merge request reports