modified various constants to be IAU nominal values

Description

Detailed description of the changes, why they are being made, etc... Also indicate appropriate tickets and tests that have been run to determine that the changes work as intended and do not introduce other problems.

API Changes and Justification

Backwards Compatible Changes

• This change introduces no API changes
• This change adds new API calls

Backwards Incompatible Changes

• This change modifies an existing API
• This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

This changes the value of LAL_GMSUN_SI in LALConstants.h to be the IAU nominal value rather than the measured value in a particular time system. This will make LAL more consistent with standard conventions of other packages such as astropy. @patricia-schmidt @aaron.zimmerman @gregory.ashton

A few other constants were updated or introduced to the IAU nominal values. I am not sure if this counts as modifying the API though.

In lalpulsar a new constant TEMPO2_MTSUN_SI is introduced to exactly match the value of that constant in TEMPO2 for compatibility. @karl-wette @david-keitel @matthew-pitkin

Some unit tests in lalsimulation needed to be modified by this change as the change affects the expected values. @sebastian-khan @geraint.pratten @maria.haney

requested review from @aaron.zimmerman, @adam-mercer, @david-keitel, @maria.haney, @patricia-schmidt, @gregory.ashton, @matthew-pitkin, @karl-wette, and @geraint.pratten

mentioned in issue #453 (closed)

Hi @jolien-creighton This will require feedback from individual waveform review teams, since the MR modifies the reviewed unit tests... @geraint.pratten and I will get in touch with the respective review chairs to collect their sign-offs.

added lal lalpulsar lalsimulation lang_python + 1 deleted label

@jolien-creighton Thanks, the LALPulsar changes look fine AFACIT, but I'll defer to @matthew-pitkin to double-check these changes

removed review request for @karl-wette and @david-keitel

approved this merge request

approved this merge request

added 1 commit

• 6d3956f6 - changed name of constants TEMPO2_MSUN_SI etc. to LAL_TEMPO2_MSUN_SI etc.

Compare with previous version

resolved all threads

approved this merge request

I have received a request from the CBC group that this should not be in the next LAL release due to ongoing O3 PE runs. So please postpone this merge until after the release.

approved this merge request

The changes to lalsimulation/test/python/reviewed_evolveorbit.asc look good to me, but maybe @riccardo.sturani should also sign off. One question: The approximate name got changed from SpinTaylorT4 to spinTaylorT4. Is there a reason?

Hi, the changes for test_phenomPv3HM.py seem ok and the test is passed when I run locally. The quantities computed differ from before the change by 1e-7 - 1e-8 relative, which is coherent with the changes in LAL_MSUN_SI and LAL_MTSUN_SI (the only constants that matter, I believe) at roughly the same relative level.

Hi All, as review chair of the NSBH models, I can confirm that the changes to the SEOBNRv4_ROM_NRTidalv2_NSBH test look good to me.

Thanks! Frank

And updates on this?

removed lang_python label

added 1870 commits

• 6d3956f6...a28f83d7 - 1861 commits from branch lscsoft:master
• f28f516d - modified various constants to be IAU nominal values
• d10a1f64 - added TEMPO2 solar mass constant for compatibiliy with TEMPO2
• ec9bb290 - loosen tolerance for test because of change of value of GMsun
• 8ddd66a0 - altered data in unit tests due to updated value of GMSUN
• cbbe8914 - make check slightly more lenient
• 160ce9ec - changed name of constants TEMPO2_MSUN_SI etc. to LAL_TEMPO2_MSUN_SI etc.
• 9d4eb92c - updated data for new value of Msun
• e311ef56 - changed LAL_TEMPO2_... to LALPULSAR_TEMPO2_...
• 2aefaec0 - changed spinTaylorT4 -> SpinTaylorT4

Compare with previous version