Skip to content

modified various constants to be IAU nominal values

Jolien Creighton requested to merge jolien-creighton/lalsuite:new-constants into master

Description

Detailed description of the changes, why they are being made, etc... Also indicate appropriate tickets and tests that have been run to determine that the changes work as intended and do not introduce other problems.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

This changes the value of LAL_GMSUN_SI in LALConstants.h to be the IAU nominal value rather than the measured value in a particular time system. This will make LAL more consistent with standard conventions of other packages such as astropy. @patricia-schmidt @aaron.zimmerman @gregory.ashton

A few other constants were updated or introduced to the IAU nominal values. I am not sure if this counts as modifying the API though.

In lalpulsar a new constant TEMPO2_MTSUN_SI is introduced to exactly match the value of that constant in TEMPO2 for compatibility. @karl-wette @david-keitel @matthew-pitkin

Some unit tests in lalsimulation needed to be modified by this change as the change affects the expected values. @sebastian-khan @geraint.pratten @maria.haney

Merge request reports