Something went wrong on our end. Please try again!
Merge imrphenomxp_nrtidalv2 branch
Compare changes
Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.
This MR adds
PhenomX
code, through flags that can be passed by the user. The default behaviour of PhenomX
models is unchangedIMRPhenomXAS_NRTidalv2
and IMRPhenomXP_NRTidalv2
, where the NRTidal_v2
extension has been ported to the PhenomX code baseline.PhenomPv2_NRTidal
models. The patch is applied in lalsimulation/lib/LALSimNRTunedTides.c
and only modifies the behaviour of current models when negative lambdas are passed, resulting in a hard XLAL error message.If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
Review complete: review statement. Review chair: @maria.haney