Skip to content

Merge imrphenomxp_nrtidalv2 branch

Marta Colleoni requested to merge waveforms/reviews/lalsuite:phenomxp_nrtidalv2-review into master

Description

This MR adds

  • additional precessing and final spin versions to existing PhenomX code, through flags that can be passed by the user. The default behaviour of PhenomX models is unchanged
  • two new tidal approximants, IMRPhenomXAS_NRTidalv2 and IMRPhenomXP_NRTidalv2, where the NRTidal_v2 extension has been ported to the PhenomX code baseline.
  • a check on the sign of tidal deformabilities which solves an existing problem in PhenomPv2_NRTidal models. The patch is applied in lalsimulation/lib/LALSimNRTunedTides.c and only modifies the behaviour of current models when negative lambdas are passed, resulting in a hard XLAL error message.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Review complete: review statement. Review chair: @maria.haney

Edited by Maria Haney

Merge request reports