Skip to content
Snippets Groups Projects

Lalinference fix

Merged Deyan Mihaylov requested to merge deyan.mihaylov/lalsuite:lalinference_fix into master

Description

Fixes an issue introduced with this MR: !2131 (comment 686372) and noticed by @john-veitch (see comments below the MR). The condition is now triggered by any 2 of the queried parameters, instead of by all 3 of them simultaneously.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

N/A

Review Status

No review has been performed here, but the change has been approved by @gregorio.carullo who chaired the LALinference portion of the review of the model.

Merge request reports

Merge request pipeline #520253 passed with warnings

Merge request pipeline passed with warnings for 5158bb86

Test coverage 28.63% (0.00%) from 1 job
Code Quality is loading
Test summary results are being parsed

Merged by Duncan MacleodDuncan Macleod 1 year ago (May 2, 2023 12:15pm UTC)

Merge details

  • Changes merged into master with fc8ee749.
  • Did not delete the source branch.

Pipeline #522426 failed

Pipeline failed for fc8ee749 on master

Test coverage 28.63% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading