Skip to content
Snippets Groups Projects

Add pSEOBNRv4HM_PA model

Merged Add pSEOBNRv4HM_PA model
waveforms/reviews/lalsuite:SEOBNRv4HM_PA into master
1 unresolved thread
Merged Deyan Mihaylov requested to merge waveforms/reviews/lalsuite:SEOBNRv4HM_PA into master
1 unresolved thread

Description

Adds 2 SEOBNR post-adiabatic models to lalsimulation: SEOBNRv4HM_PA and pSEOBNRv4HM_PA; and makes additional changes to lalinference to allow the sampling of TGR parameters (needed for the use of the latter model). The models will be used in O4 for tests of GR together with the inspiral test (separate merge request). The changes to lalinference have been used in past observing runs with the non-PA base waveform SEOBNRv4HM (onto which SEOBNRv4HM_PA is built).

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Summary of backwards-incompatible changes:

  • Function XLALSimIMRSpinAlignedEOBWaveformAll has changed signature
  • Function XLALSimIMRSpinAlignedEOBModes has changed signature
  • Function XLALSimIMREOBAttachFitRingdown has changed signature

The changes are necessary in order to be able to pass a LALdict containing the TGR parameters to the waveform model, where they would be used for computing the ringdown waveform modes. These changes will not require changes of code outside of lalsuite, i.e. the changes are not to public APIs.

Review Status

This MR has been the subject of 2 separate reviews:

  • waveform review (status complete), chaired by Marta Colleoni, wiki
  • TGR + lalinference review (status complete), chaired by Gregorio Carullo, wiki
Edited by Deyan Mihaylov

Merge request reports

Checking pipeline status.

An error occurred while fetching the artifacts
Code Quality failed to load results
Test summary failed to load results
Full report

Merged by Duncan MacleodDuncan Macleod 1 year ago (Apr 6, 2023 10:59am UTC)

Merge details

  • Changes merged into master with 4be3f28d.
  • Did not delete the source branch.

Pipeline #513367 failed

Stage: tarballs
Stage: LAL
Stage: LALFrame
Stage: LALMetaIO
Stage: LALSimulation
Stage: LALBurst
Stage: LALInspiral
Stage: LALInference
Stage: LALPulsar
Stage: LALApps
Stage: wheels
Stage: upgrade tests
Stage: docker
Stage: coverage
Stage: documentation
Stage: deploy

Pipeline failed for 4be3f28d on master

Test coverage 27.88% (0.01%) from 1 job
An error occurred while fetching the artifacts

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karl Wette
  • Deyan Mihaylov marked this merge request as ready

    marked this merge request as ready

  • Deyan Mihaylov added 170 commits

    added 170 commits

    • d81ccd3d...f78803c1 - 21 commits from branch lscsoft:master
    • 879d8299 - Post-adiabatic first commit
    • 310ec963 - Updated final radius calculation to use total spin
    • 7b7e8a50 - Fixing a variable name
    • f725a35a - Separate .h file
    • 2399d139 - Numerical derivatives
    • ee037211 - Numerical derivatives at higher orders
    • c4614814 - Finally cracked the Hamiltonian
    • c7745d5a - Fixed some numerical derivatives calls
    • 921ded01 - Added Hamiltonian call
    • b226c864 - Root finding for j0
    • eea3022f - First attempt at fluxes
    • f73f368c - Faulty flux function
    • 611dee80 - Flux wrapper edited
    • a2eb473d - UNUSED fixes
    • 9c335136 - polarDynamics memset
    • a3dc753d - Flux wrapper fix - not final
    • 19c44200 - Post-adiabatic loop included
    • ed3201bb - Include LALSimIMRSpinEOB.h fails
    • 88e79ce2 - N&R .h file
    • 359f1126 - Add Auxiliary funcs
    • eedac387 - Post-adiabatic routine added
    • ee30c312 - Quadrature integration of the result
    • 5444e8bd - Cleaned up input variables and pre-computed variables
    • 882296b7 - t(r) calculation
    • 0a199e0a - Added LALDict to the Modes function
    • 8886d734 - PA function
    • 41d10e4e - Fixes segfault
    • a1b16eb8 - pphi fixed at 2nd order
    • 7f70b7db - First attempt at full PA evolution
    • b64853fa - Fixed nu issue, changed FD derivatives
    • 9b53bdfe - Compute end part of the inspiral.
    • 5c1e34f8 - Add fast flux
    • d09ffe67 - Adding custom Flux function
    • 5cc3df9f - More optimizations
    • 5466713e - Extending the inspiral to merger
    • da6cf00b - Fix memory leak issues
    • b36c33a2 - Add forgotten GSL free
    • d62a31cf - Interpolate PA dynamics
    • ee41709b - Fixed bug with prstar rescaling
    • 0bc6b152 - Make SEOBNRv4HM_PA an actual approximant that can be called
    • c219f3af - Most recent changes
    • e4833af5 - plots directory
    • 33151e6d - Comparison plots
    • 08e0a198 - Remove static allocations
    • 4b827667 - Add corresponding frees
    • 83935961 - Add the post-adiabatic parameter calculation
    • f9763bbb - Radius change
    • 3ea2f79b - Added rSize, rFinal, and rSwitch
    • 3c263381 - Destry interpolation allocations
    • cdda67c6 - rSwitch is now a prefactor
    • 0ce475fa - Fixes to plug memory leaks
    • 50660c61 - Free up dynamicsPA memory
    • 3bbfae4b - Final memory leak fixed
    • ca2ebce9 - REsolving bug with memory alloc
    • 5da7288c - Returning the proper error functions
    • 1fc520d2 - Latest fixes
    • 55d9c54e - Added a check whether rInitial > rSwitch >= rFinal
    • 5ce6c5ca - Fix apparent bug in finding idx_stop
    • 0816288d - Failing the right way.
    • e4639aa8 - Temporary test
    • 850f6687 - Allow analytic derivatives with a flag
    • 92fd4a0f - Using the analytic derivatives in a smarter, faster way
    • c1a4cd66 - Removed some UNUSED keywords
    • c78f4b90 - Trivial changes
    • 2f4c37c7 - Restoring variable parameters
    • 5df7ca6c - ABORT to ERROR fixes
    • 0ccd4a18 - Add some optimizations
    • 755df270 - Add missing file
    • 11cf772b - Further optimizations
    • 47b630c8 - dr, rStop, rSwitch
    • 7eb9e6d5 - Fixes for PE run
    • 366a96d0 - Check if the inspiral is too short
    • 7d08da8b - Fixed memory leaks
    • a46db63d - Trying to fix the pipeline
    • 81a3c715 - Fixing the list of approximants
    • cc06010b - Changing stuff until it works
    • 7f92e691 - Added PA params argument to SimIMRSpinAlignedEOBModes
    • 330fab9b - Added documentation for the inputs
    • c9fbdb78 - Fixed white space
    • da5128c2 - Added higher modes check and addition
    • 737e0958 - New prescription
    • 12dc3295 - Fix bug in highSR initialization
    • 01d97700 - Hide SEOBNRv4_opt optimizations behind PA flagw
    • 1de3238e - Fix tc issues (hopefully)
    • 4085eff2 - Finalize changes for SEOBNRv4HM_PA
    • 436ce677 - Update FSF address to make checks happy
    • 4cf7e3be - added changes to make modified SEOBNRv4HM/SEOBNRv4HM_PA waveforms with free QNM parameters
    • cd2da184 - undid an unintended change to lalsimulation/lib/LALSimIMRSpinAlignedEOB.c
    • fce0b263 - added qnm parameters in the right order
    • 0d56ce8d - added changes to make modified SEOBNRv4HM/SEOBNRv4HM_PA waveforms with free QNM parameters
    • d873ebe6 - undid an unintended change to lalsimulation/lib/LALSimIMRSpinAlignedEOB.c
    • b7ce9a0a - added qnm parameters in the right order
    • da7cfe24 - Fix ringdown test
    • 937c4103 - Fix failure of regression test for SEOBNRv4HM
    • 186d1deb - Determine the length of ringdown from (2,2) mode as before
    • 99847804 - Remove unnecessary files
    • ca6592c1 - Change the SpinAlignedEOBversion setting
    • 79de19a8 - Added TGRParams argument to XLALSimIMRSpinAlignedEOBModes
    • 2cc81eb6 - Fix pipeline bug
    • 45a2de80 - Pipeline fix
    • 64786827 - Pipeline fix
    • efe296d6 - Move where the TGR params are unpacked
    • 5cd5a29f - Pipeline test
    • d3ee4f72 - Fix memory leak
    • 033259f5 - Use TGRParams in XLALSimIMRSpinAlignedEOBWaveformAll
    • 1bfc2479 - Fix bug with call to XLALSimIMRSpinAlignedEOBWaveformAll
    • c44c1c43 - Add documentation for TGRParams in XLALSimIMRSpinAlignedEOBWaveformAll
    • 08c3f6c8 - Documentation first iteration
    • 28cdb958 - Fix placement of closing quotes
    • 837f0c06 - Add missing documentation
    • b4a8fa13 - Soft remove of unnused functions
    • 3bd6f0c4 - Hard remove of unused functions
    • bb5025c2 - Remove unused function definitions
    • 8d9df986 - Add missing documentation to 2 functions
    • 92e740fc - Add arXiv number in documentation
    • f7c83dd5 - Fix blank space in PA files
    • 1f6fc3dd - Add support for SEOBNRv4HM_PA in XLALSimInspiralChooseTDModes
    • 043214da - Fix error call
    • 6c713a48 - Add lal/AVFactories.h to LALSimInspiral.c
    • 7718e04b - Add support for PAParams and TGRParams in XLALSimInspiralChooseTDModes
    • ef37730e - Fix the Lalpars call
    • f9e0cd2f - Fix XLALSimInspiralChooseTDModes for SEOBNRv4HM_PA
    • 8f306ade - Fix for modes sefault
    • 49a4a68a - Add unit test for SEOBNRv4HM_PA
    • b79b3415 - Propagate fixes for mass swapping
    • 52134c3d - Add test to list
    • 332c7867 - Fix typo
    • 64205583 - More typos
    • 762f0f13 - Add negative modes for XLALSimInspiralChooseTDModes
    • 418c1093 - Blank space fix
    • f339abb9 - Add TGRflag to control length of waveform
    • 0a941c46 - Check if TGRflag exists in dictionary
    • 19056b00 - Remove UNUSED variables from XLALSimInspiralChooseTDWaveform
    • 05e875c6 - Add documentation where it was missing
    • 3a1f817f - Check if TGRflag exists before getting it
    • 70713701 - Fix checks for dictionary entries
    • cb97138c - Check if LALDict exists before querying it
    • 5e4877cb - Merged commit 045b7086becd8506d0f6607bc976ff7f5da40012
    • 8dc0812d - Finish merging
    • 2e92268e - Fix number of elements in list_extra_parameters
    • 3a606cca - Add model pSEOBNRv4HM_PA
    • 4c6a67bf - Finalise pSEOBNRv4HM_PA
    • cfa8d758 - Update unit test
    • 4c01d1c4 - Don't have rich, fix test
    • b93a47cd - Update tolerances
    • 56ae776b - Fix SEOBNRv4HM_PA test
    • 0acf4515 - Fix author list
    • 5b74219a - Fix enum compatibility
    • 714bca94 - Fix authors

    Compare with previous version

    Toggle commit list
  • Deyan Mihaylov changed the description

    changed the description

  • Karl Wette
  • Deyan Mihaylov added 1 commit

    added 1 commit

    Compare with previous version

  • Deyan Mihaylov added 1 commit

    added 1 commit

    Compare with previous version

  • Deyan Mihaylov added 1 commit

    added 1 commit

    Compare with previous version

  • Karl Wette
  • Jan Steinhoff added 1 commit

    added 1 commit

    • f3a31ad6 - fixed spaces in lalsimulation/lib/Makefile.am

    Compare with previous version

  • A deleted user added apimajor label

    added apimajor label

  • Karl Wette approved this merge request

    approved this merge request

  • Jan Steinhoff added 1 commit

    added 1 commit

    • 0b34b61e - updated lalsimulation/AUTHORS

    Compare with previous version

  • Jan Steinhoff added 1 commit

    added 1 commit

    Compare with previous version

  • Deyan Mihaylov added 169 commits

    added 169 commits

    • 7e500016...6620996a - 14 commits from branch lscsoft:master
    • 9e0c7724 - Post-adiabatic first commit
    • 0e95b1cb - Updated final radius calculation to use total spin
    • 234e5915 - Fixing a variable name
    • 50a3c188 - Separate .h file
    • 15513da3 - Numerical derivatives
    • 33d0d1cb - Numerical derivatives at higher orders
    • 77fa7b79 - Finally cracked the Hamiltonian
    • 2a94f351 - Fixed some numerical derivatives calls
    • 046ea38f - Added Hamiltonian call
    • faed4118 - Root finding for j0
    • 5ef8ee5d - First attempt at fluxes
    • cdcda83d - Faulty flux function
    • 15ad8acd - Flux wrapper edited
    • 5a628321 - UNUSED fixes
    • ad6617d7 - polarDynamics memset
    • b029d31d - Flux wrapper fix - not final
    • 5e0c64df - Post-adiabatic loop included
    • 9764b7da - Include LALSimIMRSpinEOB.h fails
    • 752c6040 - N&R .h file
    • bf5282f9 - Add Auxiliary funcs
    • a770a1ff - Post-adiabatic routine added
    • 46732ec1 - Quadrature integration of the result
    • 0d5842c2 - Cleaned up input variables and pre-computed variables
    • dcb18bd7 - t(r) calculation
    • a8c889b8 - Added LALDict to the Modes function
    • 97e88769 - PA function
    • 79e5b29d - Fixes segfault
    • c4e0072a - pphi fixed at 2nd order
    • 21e75283 - First attempt at full PA evolution
    • 5e4b6c7b - Fixed nu issue, changed FD derivatives
    • 9185e9be - Compute end part of the inspiral.
    • ba34c097 - Add fast flux
    • 763e62c8 - Adding custom Flux function
    • bb4fdac4 - More optimizations
    • c829c0d2 - Extending the inspiral to merger
    • 15dccbb9 - Fix memory leak issues
    • e7ace9a2 - Add forgotten GSL free
    • cf026585 - Interpolate PA dynamics
    • 35735ff7 - Fixed bug with prstar rescaling
    • b3c2e1bb - Make SEOBNRv4HM_PA an actual approximant that can be called
    • eb6d70af - Most recent changes
    • 21fd82c8 - plots directory
    • ab67a086 - Comparison plots
    • 476279fd - Remove static allocations
    • a0ff0189 - Add corresponding frees
    • 964f21d4 - Add the post-adiabatic parameter calculation
    • ef3dc076 - Radius change
    • 5e2af428 - Added rSize, rFinal, and rSwitch
    • ac6eb1b4 - Destry interpolation allocations
    • 7c8a38d8 - rSwitch is now a prefactor
    • e61c005d - Fixes to plug memory leaks
    • 4eee5ec0 - Free up dynamicsPA memory
    • 8d9d9eb7 - Final memory leak fixed
    • 34e6c9c7 - REsolving bug with memory alloc
    • 55135406 - Returning the proper error functions
    • 137df0e1 - Latest fixes
    • 00371355 - Added a check whether rInitial > rSwitch >= rFinal
    • 65d573a3 - Fix apparent bug in finding idx_stop
    • 41310b9a - Failing the right way.
    • 23efc8de - Temporary test
    • 38f553f5 - Allow analytic derivatives with a flag
    • a39b7f87 - Using the analytic derivatives in a smarter, faster way
    • 197857db - Removed some UNUSED keywords
    • 126ad412 - Trivial changes
    • 1f380ed5 - Restoring variable parameters
    • 4fc386bc - ABORT to ERROR fixes
    • 26636abc - Add some optimizations
    • 5ff3b937 - Add missing file
    • 086c2a3a - Further optimizations
    • d1872b30 - dr, rStop, rSwitch
    • f8e0fcbe - Fixes for PE run
    • e0247104 - Check if the inspiral is too short
    • 1990d609 - Fixed memory leaks
    • be535330 - Trying to fix the pipeline
    • d86c52dd - Fixing the list of approximants
    • d4111475 - Changing stuff until it works
    • 97f049e5 - Added PA params argument to SimIMRSpinAlignedEOBModes
    • 8b60e3ba - Added documentation for the inputs
    • 4c526e8a - Fixed white space
    • f85cc31f - Added higher modes check and addition
    • bd1a48c6 - New prescription
    • aa4234a3 - Fix bug in highSR initialization
    • d411cc0f - Hide SEOBNRv4_opt optimizations behind PA flagw
    • 3832b922 - Fix tc issues (hopefully)
    • f41b88a3 - Finalize changes for SEOBNRv4HM_PA
    • 7fdefc9f - Update FSF address to make checks happy
    • 047cf718 - added changes to make modified SEOBNRv4HM/SEOBNRv4HM_PA waveforms with free QNM parameters
    • 919f34f2 - undid an unintended change to lalsimulation/lib/LALSimIMRSpinAlignedEOB.c
    • 8834a6aa - added qnm parameters in the right order
    • e177e348 - added changes to make modified SEOBNRv4HM/SEOBNRv4HM_PA waveforms with free QNM parameters
    • bd461bce - undid an unintended change to lalsimulation/lib/LALSimIMRSpinAlignedEOB.c
    • facbe742 - added qnm parameters in the right order
    • cc47e09e - Fix ringdown test
    • 5eb10e8c - Fix failure of regression test for SEOBNRv4HM
    • 90a524a2 - Determine the length of ringdown from (2,2) mode as before
    • 3fcf7d68 - Remove unnecessary files
    • d63db09c - Change the SpinAlignedEOBversion setting
    • 63e023a3 - Added TGRParams argument to XLALSimIMRSpinAlignedEOBModes
    • f0b34d49 - Fix pipeline bug
    • de16ea2d - Pipeline fix
    • 78de3b7d - Pipeline fix
    • 78bf08a2 - Move where the TGR params are unpacked
    • 951f5e21 - Pipeline test
    • 43c7dd33 - Fix memory leak
    • 7c44b9fc - Use TGRParams in XLALSimIMRSpinAlignedEOBWaveformAll
    • 145439f7 - Fix bug with call to XLALSimIMRSpinAlignedEOBWaveformAll
    • 1699543d - Add documentation for TGRParams in XLALSimIMRSpinAlignedEOBWaveformAll
    • cc525c69 - Documentation first iteration
    • 7c489340 - Fix placement of closing quotes
    • c9582c18 - Add missing documentation
    • 4904c3ce - Soft remove of unnused functions
    • 5ce99aec - Hard remove of unused functions
    • 86cdf062 - Remove unused function definitions
    • 7a2b3e3c - Add missing documentation to 2 functions
    • 22bbf70b - Add arXiv number in documentation
    • 2d32283a - Fix blank space in PA files
    • c742e782 - Add support for SEOBNRv4HM_PA in XLALSimInspiralChooseTDModes
    • 9a13edc8 - Fix error call
    • 9c05c147 - Add lal/AVFactories.h to LALSimInspiral.c
    • 703771e7 - Add support for PAParams and TGRParams in XLALSimInspiralChooseTDModes
    • 24b26249 - Fix the Lalpars call
    • 2d1f9fb5 - Fix XLALSimInspiralChooseTDModes for SEOBNRv4HM_PA
    • 04d3b3ca - Fix for modes sefault
    • f62c046b - Add unit test for SEOBNRv4HM_PA
    • 2c9fb38f - Propagate fixes for mass swapping
    • bc054c67 - Add test to list
    • 54e02097 - Fix typo
    • 50b96c46 - More typos
    • a56bfc1c - Add negative modes for XLALSimInspiralChooseTDModes
    • d99ec139 - Blank space fix
    • d57da1ba - Add TGRflag to control length of waveform
    • 09b1d8e5 - Check if TGRflag exists in dictionary
    • 3bc8de67 - Remove UNUSED variables from XLALSimInspiralChooseTDWaveform
    • c8a43deb - Add documentation where it was missing
    • 17cedf5e - Check if TGRflag exists before getting it
    • 5a062b07 - Fix checks for dictionary entries
    • 451badc7 - Check if LALDict exists before querying it
    • 9f45e100 - Merged commit 045b7086becd8506d0f6607bc976ff7f5da40012
    • b2d41919 - Finish merging
    • 937fe347 - Fix number of elements in list_extra_parameters
    • d9bcd51d - Add model pSEOBNRv4HM_PA
    • 7948eed3 - Finalise pSEOBNRv4HM_PA
    • 03b5e67b - Update unit test
    • 163d65f7 - Don't have rich, fix test
    • 2f1abc8a - Update tolerances
    • e06094fe - Fix SEOBNRv4HM_PA test
    • 238b13d9 - Fix author list
    • 4ed634bd - Fix enum compatibility
    • 4f2e3bea - Fix authors
    • 92c6aa75 - Fix Makefile.am
    • 7ae47873 - Fix Makefile.am
    • 92acf118 - Fix Makefile.am
    • f9805009 - fixed spaces in lalsimulation/lib/Makefile.am
    • d7b62a72 - updated lalsimulation/AUTHORS
    • 4f277ca6 - updated .mailmap

    Compare with previous version

    Toggle commit list
  • Deyan Mihaylov added 1 commit

    added 1 commit

    Compare with previous version

  • Jan Steinhoff added 197 commits

    added 197 commits

    • 7e9e3054...a7c2b377 - 45 commits from branch lscsoft:master
    • d9feb031 - Post-adiabatic first commit
    • 6749dada - Updated final radius calculation to use total spin
    • 26167281 - Fixing a variable name
    • 874290ab - Separate .h file
    • 582dc24c - Numerical derivatives
    • 5bac387e - Numerical derivatives at higher orders
    • 51b47466 - Finally cracked the Hamiltonian
    • 5e5f5362 - Fixed some numerical derivatives calls
    • c531926c - Added Hamiltonian call
    • 9d0721db - Root finding for j0
    • d0ba90b5 - First attempt at fluxes
    • 6f599b7d - Faulty flux function
    • ad9334f5 - Flux wrapper edited
    • 145cad49 - UNUSED fixes
    • 5a2b4ac7 - polarDynamics memset
    • d3698645 - Flux wrapper fix - not final
    • e7bcc54f - Post-adiabatic loop included
    • 2aca1388 - Include LALSimIMRSpinEOB.h fails
    • 003f01ea - N&R .h file
    • c170b3f7 - Add Auxiliary funcs
    • 1f490f7b - Post-adiabatic routine added
    • 968d8cef - Quadrature integration of the result
    • b1f07b91 - Cleaned up input variables and pre-computed variables
    • c55077f7 - t(r) calculation
    • 8812179b - Added LALDict to the Modes function
    • bbe80f94 - PA function
    • f4a49da6 - Fixes segfault
    • 4e557042 - pphi fixed at 2nd order
    • fd255961 - First attempt at full PA evolution
    • b973a639 - Fixed nu issue, changed FD derivatives
    • 3a7c5d05 - Compute end part of the inspiral.
    • 63432b8f - Add fast flux
    • 598a4a39 - Adding custom Flux function
    • 3e14ac9b - More optimizations
    • 44dd9179 - Extending the inspiral to merger
    • 30f4c0f3 - Fix memory leak issues
    • 50f0cb22 - Add forgotten GSL free
    • ceca0e1a - Interpolate PA dynamics
    • 4148e9fa - Fixed bug with prstar rescaling
    • 024c4680 - Make SEOBNRv4HM_PA an actual approximant that can be called
    • ee60de14 - Most recent changes
    • 88b40cb4 - plots directory
    • 87347596 - Comparison plots
    • 1464824a - Remove static allocations
    • e882d75b - Add corresponding frees
    • 83fb6726 - Add the post-adiabatic parameter calculation
    • f71f5d17 - Radius change
    • a1b535f4 - Added rSize, rFinal, and rSwitch
    • b32e8f8b - Destry interpolation allocations
    • 5d1dfbcf - rSwitch is now a prefactor
    • af29ac38 - Fixes to plug memory leaks
    • ff574bf3 - Free up dynamicsPA memory
    • ab86e463 - Final memory leak fixed
    • 960e1d0c - REsolving bug with memory alloc
    • 1aeb6e5f - Returning the proper error functions
    • 0610c2d6 - Latest fixes
    • 4bb4e869 - Added a check whether rInitial > rSwitch >= rFinal
    • 8202a89d - Fix apparent bug in finding idx_stop
    • 3022518d - Failing the right way.
    • 3c93cb68 - Temporary test
    • 7f729a39 - Allow analytic derivatives with a flag
    • be21e546 - Using the analytic derivatives in a smarter, faster way
    • 68acb51d - Removed some UNUSED keywords
    • cc8e64d4 - Trivial changes
    • 4b973270 - Restoring variable parameters
    • b1fe137e - ABORT to ERROR fixes
    • 4ad13e37 - Add some optimizations
    • d14ab449 - Add missing file
    • 789127e0 - Further optimizations
    • 4af4d364 - dr, rStop, rSwitch
    • 79f2e33b - Fixes for PE run
    • 1c93d564 - Check if the inspiral is too short
    • 36e072b1 - Fixed memory leaks
    • 9e1d4c7a - Trying to fix the pipeline
    • 374e4135 - Fixing the list of approximants
    • 990502b1 - Changing stuff until it works
    • 390d4376 - Added PA params argument to SimIMRSpinAlignedEOBModes
    • 6539394c - Added documentation for the inputs
    • a4d420ca - Fixed white space
    • 4a81caa8 - Added higher modes check and addition
    • c5bcfa65 - New prescription
    • 60eeffbc - Fix bug in highSR initialization
    • 1df5c961 - Hide SEOBNRv4_opt optimizations behind PA flagw
    • f2cd1b8d - Fix tc issues (hopefully)
    • 90924fe6 - Finalize changes for SEOBNRv4HM_PA
    • 68469c4e - Update FSF address to make checks happy
    • bf4d7033 - added changes to make modified SEOBNRv4HM/SEOBNRv4HM_PA waveforms with free QNM parameters
    • 27631656 - undid an unintended change to lalsimulation/lib/LALSimIMRSpinAlignedEOB.c
    • b5dd7ba4 - added qnm parameters in the right order
    • e31b195e - added changes to make modified SEOBNRv4HM/SEOBNRv4HM_PA waveforms with free QNM parameters
    • ce8a2799 - undid an unintended change to lalsimulation/lib/LALSimIMRSpinAlignedEOB.c
    • 3067b504 - added qnm parameters in the right order
    • dabe0046 - Fix ringdown test
    • fd97ad80 - Fix failure of regression test for SEOBNRv4HM
    • 7a664d6c - Determine the length of ringdown from (2,2) mode as before
    • ac2dca29 - Remove unnecessary files
    • ef5ec347 - Change the SpinAlignedEOBversion setting
    • 5618621e - Added TGRParams argument to XLALSimIMRSpinAlignedEOBModes
    • afb93f91 - Fix pipeline bug
    • cee2edb6 - Pipeline fix
    • 1e262401 - Pipeline fix
    • 16bbea35 - Move where the TGR params are unpacked
    • 08c892f0 - Pipeline test
    • 7d652c27 - Fix memory leak
    • 5504f8ba - Use TGRParams in XLALSimIMRSpinAlignedEOBWaveformAll
    • 1ea2e617 - Fix bug with call to XLALSimIMRSpinAlignedEOBWaveformAll
    • 84e302f2 - Add documentation for TGRParams in XLALSimIMRSpinAlignedEOBWaveformAll
    • b65ba383 - Documentation first iteration
    • 0ab569f8 - Fix placement of closing quotes
    • d88260fe - Add missing documentation
    • b422e627 - Soft remove of unnused functions
    • 1bd8a3f2 - Hard remove of unused functions
    • a575eac8 - Remove unused function definitions
    • 4728a289 - Add missing documentation to 2 functions
    • fd0a8ef6 - Add arXiv number in documentation
    • f01f9b3a - Fix blank space in PA files
    • 92007e32 - Add support for SEOBNRv4HM_PA in XLALSimInspiralChooseTDModes
    • 295d0285 - Fix error call
    • fa5a4303 - Add lal/AVFactories.h to LALSimInspiral.c
    • 4ae1ca9d - Add support for PAParams and TGRParams in XLALSimInspiralChooseTDModes
    • 4602f722 - Fix the Lalpars call
    • adf57c37 - Fix XLALSimInspiralChooseTDModes for SEOBNRv4HM_PA
    • ed4b3a17 - Fix for modes sefault
    • 4205bcb6 - Add unit test for SEOBNRv4HM_PA
    • 78aa9eee - Propagate fixes for mass swapping
    • bdc454b9 - Add test to list
    • 2939eb02 - Fix typo
    • 486b6c33 - More typos
    • 746a6563 - Add negative modes for XLALSimInspiralChooseTDModes
    • 1e314790 - Blank space fix
    • d2c646ca - Add TGRflag to control length of waveform
    • db16bf35 - Check if TGRflag exists in dictionary
    • cb7afe39 - Remove UNUSED variables from XLALSimInspiralChooseTDWaveform
    • fbcf6220 - Add documentation where it was missing
    • 44f49b80 - Check if TGRflag exists before getting it
    • 63e05092 - Fix checks for dictionary entries
    • b5a90162 - Check if LALDict exists before querying it
    • 16bc7147 - Merged commit 045b7086becd8506d0f6607bc976ff7f5da40012
    • c9196f91 - Finish merging
    • 6706af04 - Add model pSEOBNRv4HM_PA
    • 83a68d8a - Finalise pSEOBNRv4HM_PA
    • 39d90c32 - Update unit test
    • 459e75ef - Don't have rich, fix test
    • b5e97d1a - Update tolerances
    • a558ced4 - Fix SEOBNRv4HM_PA test
    • a0b733bb - Fix author list
    • f68b8065 - Fix enum compatibility
    • 6d84c931 - Fix authors
    • 775b5e85 - Fix Makefile.am
    • b53e962b - Fix Makefile.am
    • 1a8d202a - Fix Makefile.am
    • 8f25f2ac - fixed spaces in lalsimulation/lib/Makefile.am

    Compare with previous version

    Toggle commit list
  • Karl Wette approved this merge request

    approved this merge request

  • Maria Haney approved this merge request

    approved this merge request

  • Gregory Ashton approved this merge request

    approved this merge request

  • Deyan Mihaylov resolved all threads

    resolved all threads

  • Deyan Mihaylov changed the description

    changed the description

  • Duncan Macleod resolved all threads

    resolved all threads

  • Duncan Macleod merged

    merged

  • Duncan Macleod mentioned in commit 4be3f28d

    mentioned in commit 4be3f28d

  • Deyan Mihaylov changed the description

    changed the description

  • John Douglas Veitch
  • Deyan Mihaylov mentioned in merge request !2145 (merged)

    mentioned in merge request !2145 (merged)

  • Jan Steinhoff mentioned in merge request !1461 (closed)

    mentioned in merge request !1461 (closed)

    • Please register or sign in to reply