Something went wrong on our end. Please try again!
Use hybridized phase in SimIMRSEOBNRv5ROMTimeOfFrequency
All threads resolved!
All threads resolved!
Compare changes
Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.
This MR changes the SEOBNRv5_ROM duration function SimIMRSEOBNRv5ROMTimeOfFrequency
to use the phase hybridized with TaylorF2, instead of the pure ROM phase.
This is different from what was done in SEOBNRv4_ROM, for which PN hybridization is not implemented, and allows to use the duration function from an arbitrary starting frequency.
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
The model is reviewed (https://git.ligo.org/waveforms/reviews/seobnrv5hm_rom), but these changes should be approved by the review chair (@geraint.pratten ).