Skip to content

Use hybridized phase in SimIMRSEOBNRv5ROMTimeOfFrequency

Lorenzo Pompili requested to merge waveforms/reviews/lalsuite:hybrid-rom-duration-function into master

Description

This MR changes the SEOBNRv5_ROM duration function SimIMRSEOBNRv5ROMTimeOfFrequency to use the phase hybridized with TaylorF2, instead of the pure ROM phase.

This is different from what was done in SEOBNRv4_ROM, for which PN hybridization is not implemented, and allows to use the duration function from an arbitrary starting frequency.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

The model is reviewed (https://git.ligo.org/waveforms/reviews/seobnrv5hm_rom), but these changes should be approved by the review chair (@geraint.pratten ).

Merge request reports