Draft: v4hmpa lmax nyquist (!2183) · Merge requests · lscsoft / lalsuite · GitLab

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 30 April 2024 starting at approximately 9am PDT. It is expected to take around twenty minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Deyan Mihaylov requested to merge deyan.mihaylov/lalsuite:v4hmpa_lmax_nyquist into master Jul 29, 2023

Description

This MR makes changes to the pSEOBNRv4HM_PA model. It allows the user to pass a custom value for lmax which is to be used for the nyquist test.

API Changes and Justification

Backwards Compatible Changes

This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

This change modifies an existing class/function/struct/type definition in a public C header file or Python module
This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

This MR has been the subject of 2 separate reviews:

waveform review (status complete), chaired by Marta Colleoni, wiki
TGR + lalinference review (status complete), chaired by Gregorio Carullo, wiki

Edited Aug 02, 2023 by Deyan Mihaylov