Skip to content

Draft: v4hmpa lmax nyquist

Deyan Mihaylov requested to merge deyan.mihaylov/lalsuite:v4hmpa_lmax_nyquist into master

Description

This MR makes changes to the pSEOBNRv4HM_PA model. It allows the user to pass a custom value for lmax which is to be used for the nyquist test.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

This MR has been the subject of 2 separate reviews:

  • waveform review (status complete), chaired by Marta Colleoni, wiki
  • TGR + lalinference review (status complete), chaired by Gregorio Carullo, wiki
Edited by Deyan Mihaylov

Merge request reports