Skip to content

Modify use of environment variable in lalpulsar_MakeSFTDAG.py

Evan Goetz requested to merge evan-goetz/lalsuite:use-default-datafind-server into master

Description

This MR removes using an explicit environment variable in the gw_data_find argument list. Instead, just use the default datafind server.

I don't see any way around passing environment variables through the condor_submit_dag, however. This seems to be a new "feature" of HTCondor. Environment variables are filtered by both the dag and the jobs. Thus, users will need to submit the resulting dag file by using condor_submit_dag -include_env <dagfile> or condor_submit_dag -include_env <list of environment variables> <dagfile>

I've provided environment variables that are needed by the current workflow (the kerberos/X509 variables) and future workflow development using scitokens (bearer token and scitoken variables).

I have confirmed this change works in a production Fscan workflow. If @keith-riles adopts these changes into the online SFT production, he'll need to change the condor_submit_dag changes noted above

Closes #705 (closed)

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette or @david-keitel can have a look

Edited by Evan Goetz

Merge request reports