lal/lib/tools/TriggerInterpolate.h: use LAL COMPLEX16 types

Detailed Description

This fixes up !1282 (merged) to use LAL COMPLEX16 types in the header lal/lib/tools/TriggerInterpolate.h instead of double _Complex.

LAL's COMPLEX8/COMPLEX16 have been equivalent to C99's float/double complex for a long time. Moreover, when LAL headers are processed by a non-C99/C++ compiler, COMPLEX8/COMPLEX16 will map to binary-equivalent types from GSL. This is how LAL's C99 headers can be used to compile C++ wrappers for Octave. In short, public LAL headers should always use COMPLEX8/COMPLEX16.

LAL also defines crect(), cpolar() in LALAtomicDatatypes.h so I've removed the custom implementations.

cc @leo-singer @jolien-creighton

API Changes

Please tick one of the following options:

• These changes do not modify the API.
• These changes do modify the API, and are backwards compatible.
• These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

n/a

Review Status

n/a

assigned to @karl-wette

enabled an automatic merge when all merge checks for 937def43 pass

requested review from @kipp, @adam-mercer, and @jolien-creighton

added apinone lal labels

marked this merge request as draft

added 4 commits

• c1eac65a - gnuscripts/lalsuite_swig.m4: sort -Wno-... flags
• e97c7d27 - gnuscripts/lalsuite_swig.m4: do not warn on deprecated declarations
• bd0d68da - gnuscripts/lalsuite_swig.m4: bump serial
• 2edea31a - lal/lib/tools/TriggerInterpolate.h: use LAL COMPLEX16 types

Compare with previous version

enabled an automatic merge when all merge checks for 2edea31a pass

added infra_autotools infra_swig labels

I think that there was a good reason why I didn't use the LAL data types or even those from <complex.h>, but I don't remember what it was. This looks fine by me.

Looks fine to me.

approved this merge request

marked this merge request as ready

merged

mentioned in commit 1ab80650