Skip to content

lal/lib/tools/TriggerInterpolate.h: use LAL COMPLEX16 types

Karl Wetterequested to merge
ANU-CGA/lalsuite:TriggerInterpolate-complex into master

Detailed Description

This fixes up !1282 (merged) to use LAL COMPLEX16 types in the header lal/lib/tools/TriggerInterpolate.h instead of double _Complex.

LAL's COMPLEX8/COMPLEX16 have been equivalent to C99's float/double complex for a long time. Moreover, when LAL headers are processed by a non-C99/C++ compiler, COMPLEX8/COMPLEX16 will map to binary-equivalent types from GSL. This is how LAL's C99 headers can be used to compile C++ wrappers for Octave. In short, public LAL headers should always use COMPLEX8/COMPLEX16.

LAL also defines crect(), cpolar() in LALAtomicDatatypes.h so I've removed the custom implementations.

cc @leo-singer @jolien-creighton

API Changes

Please tick one of the following options:

  • These changes do not modify the API.
  • These changes do modify the API, and are backwards compatible.
  • These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

n/a

Review Status

n/a

Merge request reports