HeterodynedPulsarModel.c: fix typo in loop termination statement

Detailed Description

There is a typo in a loop that updates pulsar heterodyne frequency parameters if epochs are not the same between an initial set of heterodyne parameters and an updated set. The typo means that an inner loop can fail to terminate (it will output GSL errors before finally seg faulting). This MR fixes this error.

API Changes

Please tick one of the following options:

• These changes do not modify the API.
• These changes do modify the API, and are backwards compatible.
• These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

Review Status

cc @david-keitel @karl-wette @john-whelan

added lalpulsar label

requested review from @david-keitel

added apinone label

assigned to @matthew-pitkin

Though the typo is subtle, the described failure mode was an obvious breaking, so I'll merge this without asking for scientific review signoff.

approved this merge request

mentioned in commit a5084922

merged

mentioned in merge request !2464