HeterodynedPulsarModel.c: fix typo in loop termination statement

Detailed Description

There is a typo in a loop that updates pulsar heterodyne frequency parameters if epochs are not the same between an initial set of heterodyne parameters and an updated set. The typo means that an inner loop can fail to terminate (it will output GSL errors before finally seg faulting). This MR fixes this error.

API Changes

Please tick one of the following options:

• These changes do not modify the API.
• These changes do modify the API, and are backwards compatible.
• These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

Review Status

cc @david-keitel @karl-wette @john-whelan

lalpulsar/lib/HeterodynedPulsarModel.c

@@ -201,7 +201,7 @@ REAL8Vector *XLALHeterodynedPulsarPhaseDifference( PulsarParameters *params,
     /* if epochs are different update "new" frequency to heterodyne epoch */
     if ( pepoch != pepochorig ) {
       REAL8 deltatpowu = deltatpow;
-      for ( j = i + 1; i < freqsu->length; j++ ) {
+      for ( j = i + 1; j < freqsu->length; j++ ) {
         frequpdate[i] += ( freqsu->data[j] * deltatpowu ) / gsl_sf_fact( j - i );
         deltatpowu *= deltat;
       }