Skip to content

relaxing tol of frame in NRWaveform

Sebastian Khan requested to merge sebastian-khan/lalsuite:relax-nr-tol into master

See #144 (closed) for a conversation with @patricia-schmidt.

We decided relax the tolerance but both agree that we should get to the bottom of the cause of this in the future.

Here is an example how the error when it catches

I also added a print of the orbital phase (phiRef) as this is the parameter that seems to be causing the problem.

XLAL Error - XLALSimInspiralNRWaveformGetRotationAnglesFromH5File (LALSimIMRNRWaveforms.c:498): orb_phase = 1.0471975511965976

XLAL Error - XLALSimInspiralNRWaveformGetRotationAnglesFromH5File (LALSimIMRNRWaveforms.c:499): y_val = 0.0965332455799537, z_wave_y = 0.0978308678390543, fabs(y_val - z_wave_y) = 0.0012976222591006

XLAL Error - XLALSimInspiralNRWaveformGetRotationAnglesFromH5File (LALSimIMRNRWaveforms.c:500): Something's wrong in Ian's math. Tell him he's an idiot!
XLAL Error - XLALSimInspiralNRWaveformGetRotationAnglesFromH5File (LALSimIMRNRWaveforms.c:500): Input domain error

Merge request reports