Fix MMRDNP amplitudes
Compare changes
Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.
The main scope of this merge request is to fix an implementation issue with MMRDNP, by introducing a parameter representing the reference time at which the complex amplitudes were calibrated to numerical relativity.
In this technical note we explain how the problem was introduced, how it was fixed and present a few tests to check the correctness of the new implementation.
The main review wiki is here.
Apart from the amplitudes fix, in this merge request:
i) We add mass ordering to MMRDNP (see technical note);
ii) We add the (2,2,1) mode to MMRDNP (see technical note);
iii) We add a new prior option (flat in mass ratio) to MMRDNP, to facilitate comparison with IMR analyses of GW190521-like systems;
iv) We account for the reference time in all other models for which this is applicable (KHS_2012, MMRDNS).