Draft: Fix reduced chisq calculation
Related to #49
See the issue for a full description.
As with !100: this MR is mostly to share the changes for testing and further development. Don't review the changes until we've had a discussion/test of the science results.
In short, where previously we calculated cmbchisq as:
chisq_A/autocorr_norm_A + chisq_B/autocorr_norm_B + chisq_C/autocorr_norm_C in postcoh_kernel.cu and THEN divided it by nifo in postcoh.c
we now instead calculate it as:
(chisq_A + chisq_B + chisq_C) / (autocorr_norm_A + autocorr_norm_B + autocorr_norm_C)
The only way the old calculation makes sense to me is if autocorr_norm_A, autocorr_norm_B, and autocorr_norm_C were all 1 before. We'll need to check where we sourced our autocorr_norm matrix from before...
Merge request reports
Activity
changed milestone to %O3 Science Backlog
added 100 commits
-
732d7e0b...759fd30f - 93 commits from branch
spiir-O4-EW-development - 8b1a0427 - Make gracedb upload async with threads.
- ec9c900d - Merge remote-tracking branch 'origin/spiir-O4-EW-development' into ldavis__async_gracedb_upload
- 0841565b - Rename message to coinc_message.
- 0ed1a413 - Fix merge mistakes.
- ebb82bda - Merge branch 'spiir-O4-EW-development' into tdavies__fix_reduced_chisq_calculation
- 3f09a770 - Fix merge
- cd8df744 - Merge remote-tracking branch 'origin/ldavis__async_gracedb_upload' into...
Toggle commit list-
732d7e0b...759fd30f - 93 commits from branch
added 3 commits
-
dfa0d02f...266f0dea - 2 commits from branch
spiir-O4-EW-development - 4f1bfccf - Merge remote-tracking branch 'origin/spiir-O4-EW-development' into...
-
dfa0d02f...266f0dea - 2 commits from branch
mentioned in merge request !163
added 20 commits
-
4f1bfccf...baaad093 - 19 commits from branch
spiir-O4-EW-development - d69672fb - Merge branch 'spiir-O4-EW-development' into tdavies__fix_reduced_chisq_calculation
-
4f1bfccf...baaad093 - 19 commits from branch