Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S spiir
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 73
    • Issues 73
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • spiir
  • Merge requests
  • !101

Draft: Fix reduced chisq calculation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Timothy Davies requested to merge tdavies__fix_reduced_chisq_calculation into spiir-O4-EW-development Nov 16, 2022
  • Overview 0
  • Commits 4
  • Pipelines 1
  • Changes 2

Related to #49

See the issue for a full description.

As with !100: this MR is mostly to share the changes for testing and further development. Don't review the changes until we've had a discussion/test of the science results.

In short, where previously we calculated cmbchisq as: chisq_A/autocorr_norm_A + chisq_B/autocorr_norm_B + chisq_C/autocorr_norm_C in postcoh_kernel.cu and THEN divided it by nifo in postcoh.c

we now instead calculate it as: (chisq_A + chisq_B + chisq_C) / (autocorr_norm_A + autocorr_norm_B + autocorr_norm_C)

The only way the old calculation makes sense to me is if autocorr_norm_A, autocorr_norm_B, and autocorr_norm_C were all 1 before. We'll need to check where we sourced our autocorr_norm matrix from before...

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tdavies__fix_reduced_chisq_calculation