Draft: Combine science changes for MDC test
Just making a merge request as a convenient way to share these combined changes.
I should probably be using some other tool to produce a nice sharable diff.
It includes:
- remove 1.414 (still requires
sqrt(pklist->cohsnr[peak_cur]) > pklist->snglsnr[ifo_id][peak_cur]
, though as I understand that's basically redundant sincecohsnr ~= sqrt(snr_H1^2 + snr_L1^2 + ...)
- Add 0.3 min chisq threshold in postcohkernel for an IFO to contribute to cmbchisq (foregrounds and backgrounds)
- Remove superevent threshold (previously anything below this far doesn't go through additional thresholds/checks)
- finalsink only requires 1 significant IFO per trigger, but it needs:
postcoh_inspiral.snglsnr[ifo_id] >= 4.0
,postcoh_inspiral.chisq[ifo_id] < 3.0
,postcoh_inspiral.chisq[ifo_id] >= 0.4
,postcoh_inspiral.far_sngl[ifo_id] > 0.0
,postcoh_inspiral.far_sngl[ifo_id] < self.singlefar_veto_thresh
- Fixes reduced chisq calculation (
sum(chisq)/sum(autocorrnorm)
instead ofsum(chisq/autocorrnorm)/num_detectors
- i.e.
reduced cmb chisq
vssum(reduced single chisq) / num_detectors
- i.e.
Edited by Timothy Davies